On systems with older GNU system compilers, the Intel C++ compiler does
not define `__cplusplus` to any version newer than C++11.  This
prevented `bootstrap` from detecting that a given C++ standard flag has
enabled C++17 mode in the compiler.  In commit 033a4b12 (bootstrap:
Extend C++17 check for our cast functions, 2019-12-14,
v3.17.0-rc1~291^2) we added a preprocessor condition to attempt to
detect C++17 mode in the Intel compiler on such systems by looking
for `__cpp_if_constexpr`.  However, on systems with a modern GNU
system compiler, that definition is available even in C++11 mode.

Switch to using `__cpp_deduction_guides` to detect C++17 mode for the
Intel C++ compiler.  That seems to be defined exclusively in C++17 mode
regardless of the version of the system compiler.

Fixes: #21013

Brad King authored 4 years ago and Kitware Robot committed 4 years ago

61d746e5 FindOpenSSL: Detect OpenSSL 3.0.0

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !4805

Brad King authored 4 years ago and Kitware Robot committed 4 years ago

6ba84216 CPack-deb: don't add a line with a dot to pkg desc

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !4806

Currently, if the package description ends with a newline
(typically if it is read from a file) cpack -deb adds a single line
with a dot at the end which leads to a violation of the
`extended-description-contains-empty-paragraph` debian policy.

This commit fixes the above behaviour.

Fixes: #20763

Vitezslav Cizek authored 4 years ago and Brad King committed 4 years ago

The OpenSSL versioning is changing with the upcoming 3.0.0 release.
https://www.openssl.org/blog/blog/2018/11/28/version/
Since 3.0.0, the patch letters are being dropped. The new format is:
MAJOR.MINOR.PATCH

The OPENSSL_VERSION variable can now be directly derived from the new
OPENSSL_VERSION_STR macro.
https://www.openssl.org/docs/manmaster/man3/OPENSSL_VERSION_NUMBER.html

Brad King authored 4 years ago and Kitware Robot committed 4 years ago

bbb62dcc CTest: Make sure NOT_RUN tests show up in the failed test log
c5032519 Tests: Add coverage of ctest_test RETURN_VALUE and REPEAT

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !4801

Robert Maynard authored 4 years ago and Brad King committed 4 years ago

Issue: #20543

Brad King authored 4 years ago and Kitware Robot committed 4 years ago

b3e4fb51 Help: clarify add_definitions() and add_compile_definitions() behavior

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !4786

Brad King authored 4 years ago and Kitware Robot committed 4 years ago

dddb4f02 Ninja Multi-Config: Make "install" targets depend on default configs

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !4778

Fixes: #20736

And add an "install:all" target.

Fixes: #20713

Brad King authored 4 years ago and Kitware Robot committed 4 years ago

e55b21e2 CUDA: Compute CMAKE_CUDA_RUNTIME_LIBRARY default from toolchain
1086e930 CUDA: Propagate CMAKE_CUDA_RUNTIME_LIBRARY state to try_compile
a4ea2931 Help: Correct CMAKE_CUDA_RUNTIME_LIBRARY applicability

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !4762

Brad King authored 4 years ago and Kitware Robot committed 4 years ago

71e6854b FindPython: use CMAKE specific variables to look-up debug library

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !4764

Robert Maynard authored 4 years ago and Brad King committed 4 years ago

Since commit 0d014513 (CUDA: Add abstraction for cuda runtime
selection, 2019-11-29, v3.17.0-rc1~83^2) we add CUDA runtime library
selection flags by default.

To maintain backwards compatibility the default CUDA runtime
library needs to be computed based on what libraries are found
on the initial compiler invocation. For example a toolchain
could establish initial flags that have all CUDA compilations
using the runtime version, and if we don't detect this we will
try to link to both the static and shared runtime.

Co-Author: Brad King <brad.king@kitware.com>
Fixes: #20708

Brad King authored 4 years ago and Kitware Robot committed 4 years ago

88ad02f1 VS: Restore .sln support for VS Version Selector

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !4765

Merge-request: !4765

Since commit 3b51343e (VS: Emit UTF-8 BOM for generated solution files,
2019-08-19, v3.16.0-rc1~237^2) the `.sln` file does not work with the
VS Version Selector.  Add a newline after the BOM to restore support.

Fixes: #20725

Brad King authored 4 years ago and Kitware Robot committed 4 years ago

a9f4f58f cmGeneratorTarget: Clear AllConfigSources in ClearSourcesCache

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !4751

Fixes: #20714

Brad King authored 4 years ago and Kitware Robot committed 4 years ago

3719ddd3 Help: Add 3.16.7 release note for FindPkgConfig '-isystem' fix

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !4752

Merge-request: !4751

Merge-request: !4752

Add a release note for the change in commit 4d446c68 (FindPkgConfig:
also handle "-isystem" prefixes for include directories, 2020-04-30).

Brad King authored 4 years ago and Kitware Robot committed 4 years ago

13ea1907 Help: Add 3.17.3 release note for Objective C/C++ compiler selection
16bf978e Merge branch 'backport-3.16-objc-env-vars' into objc-env-vars
67b9f55d Objective C/C++: Honor CC and CXX env vars to select compiler
ab9be666 Help: Document OBJC and OBJCXX env vars for Objective C/C++ compilers

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !4746

In commit 40aa6c05 (cmGeneratorTarget: Add method to collect all
sources for all configs, 2017-04-10, v3.9.0-rc1~268^2~5) we forgot to
update `ClearSourcesCache` to also clear `AllConfigSources`.  This leads
to subtle cases where code paths like PCH handling that add sources
during generation break depending on ordering.

Suggested-by: Christian Fersch
Fixes: #20712, #20702

Port the 3.16.7 release note for 3.17.3 too.

If the `OBJC` or `OBJCXX` environment variable is not set to specify an
Objective C or C++ compiler, check `CC` or `CXX` too.

Fixes: #20703

Brad King authored 4 years ago and Kitware Robot committed 4 years ago

0199dd9f ExternalProject: expose _ep_cache_args_script to the caller

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !4710

This is needed so that the caller can add a dependency on the cache
file.

Fixes: #20668

Brad King authored 4 years ago and Kitware Robot committed 4 years ago

6b2fb4ff VS: Fix using PCH from source with COMPILE_OPTIONS

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !4734