Francois Keith authored 4 years ago and Brad King committed 4 years ago

This allows listing the warnings that must be flagged as errors.
For example:

    target_compile_options(proj PRIVATE "/warnaserror:1998,4014")

Sergey Bronnikov authored 4 years ago and Brad King committed 4 years ago

Rename `CMAKE_FUNCTION_TABLE_{ENTIRES => ENTRIES}`.

The `-std:c11` option added by commit f7347f28 (MSVC: Record support
for C11 and c_restrict, 2020-08-09, v3.18.2~9^2) needs this flag table
entry to map in the VS IDE properly.

Issue: #21069

Fixes #20164

clang-analyzer has a check for any use of `strcpy`. This usage is safe
because it is allocated above using the length of the string.

While the flag tables for C and C++ were generated from MSBuild `.xml`
files, the CSharp flag tables were written by hand.  Copy the `v141`
flag table to use for the `v142` toolset.

Remove the special case added by commit 626c51f4 (VS: Update for
Visual Studio 2019 Preview 2, 2019-01-24, v3.14.0-rc1~74^2) that mapped
the v142 flag table lookup to v141 since we now have the real v142
table.

Fixes: #19828

Wil Stark authored 6 years ago and Brad King committed 6 years ago

Warning disables are transferred to the VS IDE `<NoWarn>` node.

Fixes: #18878

lucy phipps authored 6 years ago and Brad King committed 6 years ago

Use FileOptimizer 13.50.2431 (x86) and ZopfliPNG 1.0.2.

Update expected file hashes in tests.

Apply the change from commit 454b47ba (VS: Fix MANIFESTUAC link flag
map to .vcxproj elements, 2018-11-21) to the v142 flag table.

Add special parsing of the flags given in `/MANIFESTUAC:"..."` in order
to map them correctly to `.vcxproj` elements.

Keep the old incorrect flag table entries for `uiAccess` and `level`
flags for compatibility even though they do not really exist.

Apply the change from commit 57a78b55 (VS: Fix support for '/guard:cf'
linker flag, 2018-11-21) to the v142 flag table.

Although `$(VCTargetsPath)/1033/link.xml` contains an entry for
`LinkControlFlowGuard`, it does not work when used in a `.vcxproj` file
(at least as of v140 and v141).  Drop our link flag table entries for
these toolsets so that the flag will be passed via `AdditionalOptions`.

Apply the changes from commit a5d9aa50 (VS: Map the link `/debug` to
its IDE property, 2018-11-21) and commit f77320c1 (VS: Add v140 and
v141 flag table entries for /DEBUG:NONE and /DEBUG:FULL, 2018-11-21) to
the v142 flag table.

See commit ae44496e (VS: Fix GenerateDebugInformation values for v140
and v141 toolsets, 2017-06-27, v3.9.0-rc6~15^2~1) for explanation.

Apply the change from commit 1d00fd77 (VS: Fix /MANIFESTUAC:NO linker
option mapping, 2018-11-21) to the v142 flag table.

There are no versions of `/MANIFESTUAC:NO` where addition values are
appended.  Remove both of the `MANIFESTUAC:NO` entries from our flag
tables and replace them with one which would set `EnableUAC` to false
and immediately stop processing the `/MANIFESTUAC:NO` option.

Apply the change from commit e0d6d01e (VS: Add flag table entry for
"permissive" flag to disable conformance mode, 2018-12-10) to the
v142 flag table.

Add the negative form of the option.

Rather than the change from commit 584ad067 (VS: Fix flag table entry
for -Qspectre, 2018-11-26), update the v142 flag table with an actual
flag for the negative form of the flag.  Switch the entry order so that
the longer negative form is first.

Apply the change from commit 8df25f94 (VS: connect /Y- compiler option
with "Not Using Precompiled Headers", 2018-11-26) to the v142 flag
table.

Apply the change from commit f1223e34 (VS: Add v140 flag table entries
for `-Zc:inline[-]`, 2018-11-26) to the v142 flag table.

The documentation of this option [1] claims that the default is off, but
VS seems to use `-Zc:inline` by default if `RemoveUnreferencedCodeData`
does not appear in the `.vcxproj` file.  Add the flag table entry to
allow use of the flag to be configured.

[1] https://msdn.microsoft.com/en-us/library/dn642448.aspx

Apply the change from commit 44dc9fc4 (VS: Fix /analyze:log flag
mapping, 2018-11-26) to the v142 flag table.

The `/analyze:log` argument requires a value in the following argument.
Also drop the general `/analyze:` flag table entry so that such flags
will be passed through as plain additional options.  This is necessary
because some such options have following values and some do not but
not all have `.vcxproj` elements to hold the values.

Convert from MSBuild `.xml` files:

    python cmConvertMSBuildXMLToJSON.py -t v142 .../2019/Preview/MSBuild/Microsoft/VC/v160/1033/cl.xml
    python cmConvertMSBuildXMLToJSON.py -t v142 .../2019/Preview/MSBuild/Microsoft/VC/v160/1033/link.xml

This flag is required to disable conformance mode on specific sources
when it is otherwise enabled on most sources.

Original header commit 516c6fc3

Add support for mapping Just My Code compiler flag

The Qspectre option was generated by the script (as opposed to
being added by commit v3.13.0-rc1~4^2 (VS: Add flag table entry for
-Qspectre, 2018-10-08), however the comment was not useful and
there was a separate off option generated that was not in the
old table.

Original header commit v3.10.0-rc1~423^2

The change allows to selectively disable PrecompiledHeaders.
Despite the `$(VCTargetsPath)/1033/cl.xml` contains an empty value for switch,
for effectively turn off setting need to use /Y- option as described on msdn:
https://msdn.microsoft.com/en-us/library/1hy7a92h.aspx

Note: Zc:inline was added by generator, but not the - version.

Original header commit v3.7.2~8^2

The documentation of this option [1] claims that the default is off, but
VS seems to use `-Zc:inline` by default if `RemoveUnreferencedCodeData`
does not appear in the `.vcxproj` file.  Add the flag table entry to
allow use of the flag to be configured.

[1] https://msdn.microsoft.com/en-us/library/dn642448.aspx

Original header commit v3.6.0-rc3~8^2

In commit v3.6.0-rc1~279^2~10 (VS: in Clang/C2 toolset, setup correct
compiler settings, 2016-02-18) a flag mapping was added for the clang
`-Os` flag.  However, this collides with a mapping we already had for
the MSVC flag of the same name.  This is a symptom of a larger problem
in that the VS generators need a per-toolset flag map (issue #16153).

For now, simply drop the new mapping and drop `-Os` from clang compiler
flags in the MinSizeRel configuration.

Original header commit v3.6.0-rc1~279^2~8

This is used by the Clang/C2 toolset.

Original header commit v3.6.0-rc1~279^2~10

Original header commits:
 v11/v12 commit v3.1.0-rc1~695^2
 v140/v141 commit v3.1.0-rc1~358^2~3

Fix the VS 11 and VS 12 flag table entries for this flag.  It requires
a value in the following argument.  Also drop the general "/analyze:"
flag table entry so that such flags will be passed through as plain
additional options.  This is necessary because some such options have
following values and some do not but not all have .vcxproj elements
to hold the values.

Original header commit v3.13.0-rc2~6^2

Add a missing `:` to these entries in the flag table.  The user
value is always required and must come after the `:`.

Original header commit v3.10.0-rc1~494^2

if /nowin32manifest is specified, it will be preferred over any
occurring /win32manifest:<file> parameter

The v141_Link.json already appeared to have the option included, so
onlyh adding the change to v14_LIB.json.

Original header commit v3.10.0-rc1~132^2

Visual Studio 15.4 adds support for this architecture.

Original header commit v3.10.0-rc1~97^2

Add special parsing of the flags given in `/MANIFESTUAC:"..."` in order
to map them correctly to `.vcxproj` elements.

Keep the old incorrect flag table entries for `uiAccess` and `level`
flags for compatibility even though they do not really exist.

Fixes: #16563

Original header commit v3.9.0-rc6~12^2

Although `$(VCTargetsPath)/1033/link.xml` for v140 and v141 toolsets
contains an entry for `LinkControlFlowGuard`, it does not work when used
in a `.vcxproj` file.  Drop our link flag table entries for these
toolsets so that the flag will be passed via `AdditionalOptions`.

DEBUG:FULL was already added for v141 from the generation.

Original header commit v3.9.0-rc6~15^2

Fix issues with "GenerateDebugInformation". These
are mostly from the following commits, but also
include a related fix to the v140/v141 file.

Original header commits:
 v10-v14 commit v3.5.0-rc1~71^2
 v140/v141 commit v3.9.0-rc6~15^2~1

Original header commits:
 v10/v11/v12 commit v3.0.0-rc5~3^2
 v140 commit v3.1.0-rc1~358^2~3

There are no versions of /MANIFESTUAC:NO where addition values are
appended.  Remove both of the MANIFESTUAC:NO entries from our flag
tables and replace them with one which would set EnableUAC to false and
immediately stop processing the /MANIFESTUAC:NO option.