- Mar 22, 2020
-
-
Kitware Robot authored
-
- Mar 21, 2020
-
-
Kitware Robot authored
-
- Mar 20, 2020
-
-
Brad King authored
-
-
-
75331a45 FindMatlab: Add R2020a=9.8 Acked-by:
Kitware Robot <kwrobot@kitware.com> Merge-request: !4507
-
75331a45 FindMatlab: Add R2020a=9.8 Acked-by:
-
Brad King authored
-
417b765f GetPrerequisites: Classify vcruntime libraries as system Acked-by:
-
-
417b765f GetPrerequisites: Classify vcruntime libraries as system Acked-by:
-
-
8affe9aa export: Fix use-after-free on multiple calls overwriting same FILE Acked-by:
-
8affe9aa export: Fix use-after-free on multiple calls overwriting same FILE Acked-by:
-
Kitware Robot authored
-
- Mar 19, 2020
-
-
This allows Matlab R2020a to be recognized as a valid Matlab version.
-
Brad King authored
Merge-request: !4506
-
Previously GetPrerequisites classified `vcruntime*.dll` as type "other". They should be classified as type "system".
-
bd891335 cmState::GetCacheEntryValue: return cmProp Acked-by:
-
b915fec5 cmTarget: minor code improvements Acked-by:
-
36baf1f1 CheckLanguage: hide commonly used variable names Acked-by:
-
-
1994f950 cmake: List valid values for --trace-format on the command line e39766d8 Help: Fix documentation of --trace-format parameter Acked-by:
-
1994f950 cmake: List valid values for --trace-format on the command line e39766d8 Help: Fix documentation of --trace-format parameter Acked-by:
-
Brad King authored
CMake 3.16 and below allow multiple `export()` calls with the same output file even without using `APPEND`. The implementation worked by accident by leaking memory. Refactoring in commit 5444a809 (cmGlobalGenerator: modernize memrory managemenbt, 2019-12-29, v3.17.0-rc1~239^2) cleaned up that memory leak and converted it to a use-after-free instead. The problem is caused by using the `cmGlobalGenerator::BuildExportSets` map to own `cmExportBuildFileGenerator` instances. It can own only one instance per output FILE name at a time, so repeating use of the same file now frees the old `cmExportBuildFileGenerator` instance and leaves the pointer in the `cmMakefile::ExportBuildFileGenerators` vector dangling. Move ownership of the instances into `cmMakefile`'s vector since its entries are not replaced on a repeat output FILE. In future work we should introduce a policy to error out on this case. For now simply fix the use-after-free to restore CMake <= 3.16 behavior. Fixes: #20469
-
Kitware Robot authored
-
- Mar 18, 2020
-
-
Kyle Edwards authored
-
Kyle Edwards authored
-
Hannes Vogt authored
The check_language sets internal variables with a common name in the caller's scope: `result`, `output` and `content`. They are now prefixed with `_cl_`, inspired by the CheckLibraryExists module.
-
46064c81 FindRuby: Add support for versions up to 2.7 675eaf3b FindRuby: Update MSVC runtime library selection b970e25d FindRuby: Remove extra whitespace ecdace4d FindRuby: Include FPHSA closer to where it is used f52f4961 FindRuby: Provide Ruby_LIBRARIES result variable b00d736a FindRuby: Add dedicated tests Acked-by:
-
1c99f5df FindPkgConfig: Add test for specified pkg-config tool missing b59f36aa FindPkgConfig: Unset results when pkg-config is broken Acked-by:
-
2ec6fbcb bootstrap: Tolerate trailing content in CMakeVersion.cmake components Acked-by:
-
cc7f116c FindPython: fix regression on version validation Acked-by:
-
-
cc7f116c FindPython: fix regression on version validation Acked-by:
-
Kitware Robot authored
-
- Mar 17, 2020
-
-
Vitaly Stakhovsky authored
-
In commit 3dab4682 (FindPython: reduces consumption of resources, 2020-02-10, v3.17.0-rc1~11^2) we accidentally broke the python executable version validation when the "LOCATION" strategy is used with the plain `FindPython` module. Fix the logic and add test cases covering those combinations. Fixes: #20465
-
Fixes: #20370
-
Brad King authored
Use the `MSVC_TOOLSET_VERSION` variable computed by CMake to get the matching Ruby library name component. Inspired-by:Julien Marrec <julien.marrec@gmail.com>
-
