Signed-off-by: Vicente Adolfo Bolea Sanchez <vicente.bolea@kitware.com>

Sujin Philip authored 3 years ago and Kitware Robot committed 3 years ago

abedf61e Fix probe filter field mapping

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Kenneth Moreland <morelandkd@ornl.gov>
Merge-request: !2555

Li-Ta Lo authored 3 years ago and Kitware Robot committed 3 years ago

e7db8ef7 add build/config to the list of file to be packed for windows
a5f40f7a add build/config to the list of file to be packed
c6e06d45 more trial
167afd89 move configure_file after configure_package_config_file
e5338b60 how about the other
6cd30dac restore install of vtkm_config.mk
4f699218 temporary disable config files
ecf27e06 Merge branch 'master' into mk_config
...

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Matt Larsen <larsen30@llnl.gov>
Merge-request: !2536

Kenneth Moreland authored 3 years ago and Kitware Robot committed 3 years ago

bb7661c1 Fix recursive header file dependancies

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Li-Ta Lo <ollie@lanl.gov>
Merge-request: !2552

Kenneth Moreland authored 3 years ago and Kitware Robot committed 3 years ago

3feff368 Save device choice on spawned control threads

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Li-Ta Lo <ollie@lanl.gov>
Merge-request: !2543

All probed fields should become point fields in output

Sujin Philip authored 3 years ago and Kitware Robot committed 3 years ago

9bb10b39 Fix VTKDataSetWriter writing `char` types

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Kenneth Moreland <morelandkd@ornl.gov>
Merge-request: !2538

Kenneth Moreland authored 3 years ago and Kitware Robot committed 3 years ago

69bacdfc Fix deprecation warning in histogram example

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Sujin Philip <sujin.philip@kitware.com>
Merge-request: !2553

The examples do not get compiled as often as the test, so minor issues
sometimes creep in. The histogram example was still using some
deprecated methods.

Having UnknownArrayHandle.h include DefaultTypes.h is problematic,
because that header includes lots of other classes like cell sets.
Keeping these from in turn depending back on UnknownArrayHandle.h is
difficult. So this dependancy is broken.

Dave Pugmire authored 3 years ago and Kitware Robot committed 3 years ago

0ea4470f Simplify the code a little.
17964310 Cleanup. remove prints.
50a42a14 Forgot to add header to CMakeLists.txt
f8021dbc Add threaded filters for multiblock dataset.

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Kenneth Moreland <morelandkd@ornl.gov>
Merge-request: !2548

Kenneth Moreland authored 3 years ago and Kitware Robot committed 3 years ago

1ec4e5d6 Improve type reporting in `UnknownArrayHandle`
6f5455d0 Enable `TypeToString` for `type_info`

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Li-Ta Lo <ollie@lanl.gov>
Merge-request: !2546

Added features with reporting types with `UnknownArrayHandle`. First,
added a method named `GetArrayTypeName` that returns a string containing
the type of the contained array. There were already methods
`GetValueType` and `GetStorageType`, but this provides a convenience to
get the whole name in one go.

Also improved the reporting when an `AsArrayHandle` call failed. Before,
the thrown method just reported that the `UnknownArrayHandle` could not
be converted to the given type. Now, it also reports the type actually
held by the `UnknownArrayHandle` so the user can better understand why
the conversion failed.

VTK-m contains a helpful method named `vtkm::cont::TypeToString` that
either takes a type as a template argument or a `std::type_info` object
and returns a human-readable string for that type.

The standard C++ library has an alternate for `std::type_info` named
`std::type_index`, which has the added ability to be used in a container
like `set` or `map`. The `TypeToString` overloads have been extended to
also accept a `std::type_info` and report the name of the type stored in
it (rather than the name of `type_info` itself).

Dave Pugmire authored 3 years ago and Kitware Robot committed 3 years ago

6f8d1466 Fixes for compiler warnings.

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Kenneth Moreland <morelandkd@ornl.gov>
Merge-request: !2547

Dave Pugmire authored 3 years ago and Kitware Robot committed 3 years ago

39054e64 Add corner case unit test.
0a3fd262 Add test file for corner case.
4b0896bd Fix for corner case in particle advection.

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Abhishek Yenpure <abhishek@uoregon.edu>
Merge-request: !2545

Kenneth Moreland authored 3 years ago and Kitware Robot committed 3 years ago

869535b2 Remove uses of ScopedCudaStackSize
4bf8bfb1 Deprecate KdTree3D worklets
5fa402ac Remove recursion from FloatDistance
fc58f4ed Turn on CUDA warnings for unknown stack sizes

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Dave Pugmire <dpugmire@gmail.com>
Merge-request: !2535

Since we have (hopefully) gotten rid of all unbounded recursion and
calls to function pointers or virtual methods, the CUDA compiler should
be able to statically determine the size of the stack needed. Thus, we
shouldn't need `ScopedCudaStackSize` at all.

However, there is one odd case where using it seems to be necessary. It
is unclear why, but that is an issue for another day.

The implementation of the search in the k-d tree is problematic because
it uses unbounded recursion. This is a problem for GPU devices, which
have very short stacks set by how many calls the compiler determines.
This is fixable, but the fix is not trivial.

This class is not used anywhere in VTK-m other than a trivial test.
Thus, I am just deprecating the class. I am also deleting the test, so
the code is not run anymore.

The maximum recursion that could happen was 1 call in, but compilers had
trouble determining that. Split this into 2 non-recursive functions so
the compiler can easily determine the stack depth.

These were previously suppressed because they are unavoidable when
calling virtual methods. But we no longer support virtual methods on
devices (it is deprecated).

These warnings can still happen if you have unbounded recursion. But we
would like to avoid unbounded recursion, so we would like to see these
warnings.

Also turned on other nvlink warnings, which include when a recursive
function call means that the compiler cannot figure out the full
stack depth.

Vicente Bolea authored 3 years ago and Kitware Robot committed 3 years ago

7ea28273 LFS: Set default url to the current origin url

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !2532

The `RuntimeDeviceTracker` is a thread-local variable that monitors the
devices to use separately on each thread. This is an important feature
to allow different threads to control different devices.

When a tracker is created on a new thread, it was simply reset, which
makes sense. However, the reset does not take into account the device
selected by `vtkm::cont::Initialize`. This means that if VTK-m was used
in a different thread than it was initialized, it would ignore the
`--vtkm-device` parameter.

To get around this problem, keep track of the `RuntimeDeviceTracker` on
the "main" thread. When a `RuntimeDeviceTracker` is created on a new
thread, it copies the state from that tracker.

Kenneth Moreland authored 3 years ago and Kitware Robot committed 3 years ago

62411796 Add RuntimeDeviceTracker::CopyState

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Li-Ta Lo <ollie@lanl.gov>
Merge-request: !2540

Kenneth Moreland authored 3 years ago and Kitware Robot committed 3 years ago

34615a98 Deprecate ArrayHandle::GetDeviceAdapterId

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Li-Ta Lo <ollie@lanl.gov>
Merge-request: !2534

It is sometimes the case that you want to copy the state of one
`RuntimeDeviceTracker` to another. This is particularly the case when
creating threads in the control environment. Each thread has its own
copy of `RuntimeDeviceTracker`, so when you spawn a thread you probably
want to copy the state of the tracker from the calling thread.

This method is a remenant of when `ArrayHandle` could only store data on
one device at a time. It is now capable of storing data on any number of
devices (as well as the host), so asking for "the" device no longer
makes sense. Thus, this method is deprecated in favor of
`ArrayHandle::IsOnDevice`.

This deprecation leads to fixing some older functionality that still
assumed data could only be on one device at a time.

Fixes #592.