Skip to content

Add DynamicPoint

Dmitriy Morozov requested to merge mrzv/diy:dynamic-point into master
  • Add DynamicPoint class (runtime dimension) in include/diy/dynamic-points.hpp
  • Switch Bounds to use DynamicPoint
  • Mark Bounds::Bounds() as deprecated and fix all its uses
  • Switch Direction to use DynamicPoint
  • Mark Direction::Direction(int dir) as deprecated (in favor of Direction::Direction(int dim, int dir))
  • Change the behavior of Direction::Direction() (initializing to 0-dimensional direction). This one is dangerous, but I don't see any other way. We need to default constructor in Serialization, so we can't just mark it as deprecated. But keeping the old behavior (initializing to DIY_MAX_DIM dimensions) is also undesirable. Although the latter would be a safer option: it wouldn't break old code, as far as I can tell.

@tpeterka It's ready for your review.

Merge request reports