Draft: Improvements to threading and Qt GUI handling

Observers are now run on the threads that they are triggered on. Implemented qtInvokeOnMainThreadBehavior to handle observers for gui elements and to provide a general purpose mechanism to run logic on the gui thread. Refactored gui components that are observer-driven to use qtInvokeOnMainThread.

Errors:

• commit 6e6a52aa is not allowed; missing newline at the end of file in smtk/extension/qt/qtInvokeOnMainThreadBehavior.cxx.
• commit 6e6a52aa is not allowed because the following files are not formatted according to the 'clang-format' check: smtk/extension/paraview/operators/smtkAssignColorsView.cxx, smtk/extension/paraview/operators/smtkCoordinateTransformView.cxx, smtk/extension/paraview/operators/smtkDataSetInfoInspectorView.cxx, smtk/extension/paraview/widgets/pqSMTKTransformWidget.cxx, smtk/extension/qt/diagram/qtDefaultTaskNode.cxx, and 3 others. Post a comment ending in the line Do: reformat to rewrite the MR source branch automatically.

Warnings:

• please consider adding a changelog entry in a file ending with .rst in doc/release/notes.
• the merge request is marked as a work-in-progress.

The warnings do not need to be fixed, but it is recommended to do so.

Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.

added 1 commit

• 9096617a - Added smtk::common::Context to Operation API

Compare with previous version

Errors:

• commit 6e6a52aa is not allowed; missing newline at the end of file in smtk/extension/qt/qtInvokeOnMainThreadBehavior.cxx.

• commit 6e6a52aa is not allowed because the following files are not formatted according to the 'clang-format' check: smtk/extension/paraview/operators/smtkAssignColorsView.cxx, smtk/extension/paraview/operators/smtkCoordinateTransformView.cxx, smtk/extension/paraview/operators/smtkDataSetInfoInspectorView.cxx, smtk/extension/paraview/widgets/pqSMTKTransformWidget.cxx, smtk/extension/qt/diagram/qtDefaultTaskNode.cxx, and 3 others. Post a comment ending in the line Do: reformat to rewrite the MR source branch automatically.

• commit 9096617a is not allowed; missing newline at the end of file in smtk/common/Context.h.

• commit 9096617a adds bad whitespace:

  smtk/operation/Operation.cxx:197: tab in indent.
  +		if (auto parentKey = ctx.value<parentOperationKey, BaseKey>())
  smtk/operation/Operation.cxx:199: tab in indent.
  +		  // Inherit resource locks from the context.

• commit 9096617a is not allowed because the following files are not formatted according to the 'clang-format' check: smtk/common/Context.h, smtk/extension/paraview/appcomponents/pqSMTKAppComponentsAutoStart.cxx, smtk/extension/paraview/appcomponents/pqSMTKCallObserversOnMainThreadBehavior.cxx, smtk/extension/paraview/appcomponents/pqSMTKCloseWithActiveOperationBehavior.cxx, smtk/extension/paraview/appcomponents/pqSMTKOperationHintsBehavior.cxx, and 29 others. Post a comment ending in the line Do: reformat to rewrite the MR source branch automatically.

Warnings:

• please consider adding a changelog entry in a file ending with .rst in doc/release/notes.
• the merge request is marked as a work-in-progress.

The warnings do not need to be fixed, but it is recommended to do so.

Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.

closed