Skip to content
Snippets Groups Projects

Arc deletion

Merged David Thompson requested to merge dcthomp/smtk:arc-bark into master
  • Refactor qtTaskEditor to separate interaction modes from the editor itself.
  • Add a "disconnect" mode that allows users to select and remove arcs (if an operation is present that can perform the removal).
  • Fix an issue where the "pan" mode event filters were not installed at construction of the qtTaskEditor.
Edited by David Thompson

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • assigned to @dcthomp

  • Errors:

    • commit b49e2adf is not allowed because the following files are not formatted according to the 'clang-format' check: smtk/extension/qt/task/qtGraphViewMode.cxx, smtk/extension/qt/task/qtGraphViewMode.h, smtk/extension/qt/task/qtPanMode.cxx, smtk/extension/qt/task/qtPanMode.h, smtk/extension/qt/task/qtTaskView.cxx. Post a comment ending in the line Do: reformat to rewrite the MR source branch automatically.
    • commit b49e2adf cannot be merged; it is marked as a work-in-progress (WIP).
    • commit f90bc9ec is not allowed because the following files are not formatted according to the 'clang-format' check: smtk/extension/qt/task/qtConnectMode.cxx, smtk/extension/qt/task/qtConnectMode.h, smtk/extension/qt/task/qtGraphViewMode.h, smtk/extension/qt/task/qtPanMode.cxx, smtk/extension/qt/task/qtPanMode.h, and 4 others. Post a comment ending in the line Do: reformat to rewrite the MR source branch automatically.
    • commit f90bc9ec cannot be merged; it is marked as a work-in-progress (WIP).
    • commit 1d7d8012 is not allowed because the following files are not formatted according to the 'clang-format' check: smtk/extension/qt/task/qtConnectMode.cxx, smtk/extension/qt/task/qtDisconnectMode.cxx, smtk/extension/qt/task/qtDisconnectMode.h, smtk/extension/qt/task/qtPanMode.h, smtk/extension/qt/task/qtTaskEditor.cxx. Post a comment ending in the line Do: reformat to rewrite the MR source branch automatically.
    • commit 1d7d8012 cannot be merged; it is marked as a work-in-progress (WIP).

    Warnings:

    • please consider adding a changelog entry in a file ending with .rst in doc/release/notes.

    The warnings do not need to be fixed, but it is recommended to do so.

    Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.

  • David Thompson changed title from Arc bark to Arc deletion

    changed title from Arc bark to Arc deletion

  • David Thompson changed the description

    changed the description

  • David Thompson added 1 commit

    added 1 commit

    Compare with previous version

  • Author Maintainer

    Do: reformat

  • Errors:

    • commit 6a49a003 is not allowed because the following files are not formatted according to the 'clang-format' check: smtk/extension/qt/task/qtConnectMode.cxx, smtk/extension/qt/task/qtConnectMode.h, smtk/extension/qt/task/qtDisconnectMode.cxx, smtk/extension/qt/task/qtDisconnectMode.h, smtk/extension/qt/task/qtGraphViewMode.cxx, and 7 others. Post a comment ending in the line Do: reformat to rewrite the MR source branch automatically.

    Warnings:

    • please consider adding a changelog entry in a file ending with .rst in doc/release/notes.

    The warnings do not need to be fixed, but it is recommended to do so.

    Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.

  • This topic has been reformatted and pushed; please fetch from the source repository and reset your local branch to continue with further development on the reformatted commits.

  • David Thompson added 1 commit

    added 1 commit

    Compare with previous version

  • Warnings:

    • please consider adding a changelog entry in a file ending with .rst in doc/release/notes.

    The warnings do not need to be fixed, but it is recommended to do so.

  • David Thompson added 1 commit

    added 1 commit

    Compare with previous version

  • Warnings:

    • please consider adding a changelog entry in a file ending with .rst in doc/release/notes.

    The warnings do not need to be fixed, but it is recommended to do so.

  • David Thompson requested review from @bob.obara

    requested review from @bob.obara

  • David Thompson added 1 commit

    added 1 commit

    Compare with previous version

  • Errors:

    • commit ba5c7544 is not allowed because the following files are not formatted according to the 'clang-format' check: smtk/extension/qt/task/qtTaskEditor.cxx. Post a comment ending in the line Do: reformat to rewrite the MR source branch automatically.

    Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.

  • Author Maintainer

    Do: reformat

  • This topic has been reformatted and pushed; please fetch from the source repository and reset your local branch to continue with further development on the reformatted commits.

  • David Thompson added 1 commit

    added 1 commit

    Compare with previous version

  • David Thompson changed milestone to %smtk 24.01

    changed milestone to %smtk 24.01

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading