Change how SMTK plugins get initialized.

assigned to @dcthomp

@ben.boeckel @john.tourtellott This MR depends on paraview/paraview!5283 (merged) . It fixes #447 (closed) but will require the bump to the superbuild's ParaView in cmb-superbuild!803 (merged) .

requested review from @ben.boeckel

+1 Marking as a draft due to it being blocked on other things.

marked this merge request as draft

added 13 commits

• 80b66426...c4240868 - 12 commits from branch cmb:master
• 2da5e2e2 - Change how SMTK plugins get initialized.

Compare with previous version

Errors:

• commit 2da5e2e2 is not allowed because the following files are not formatted according to the 'clang-format' check: smtk/extension/paraview/server/vtkSMTKResourceRepresentation.cxx. Post a comment ending in the line Do: reformat to rewrite the MR source branch automatically.

Warnings:

• the merge request is marked as a work-in-progress.

The warnings do not need to be fixed, but it is recommended to do so.

Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.

Do: reformat

This topic has been reformatted and pushed; please fetch from the source repository and reset your local branch to continue with further development on the reformatted commits.

added 1 commit

• 26c7d016 - Change how SMTK plugins get initialized.

Compare with previous version

Warnings:

• the merge request is marked as a work-in-progress.

The warnings do not need to be fixed, but it is recommended to do so.

@aron.helser Now that cmb-superbuild!803 (merged) is in, can you update the CI images once they are pushed by the nightly superbuild? This MR can get tested after you do that or you can force-push new docker-image/artifact-SHAs to this MR.

assigned to @aron.helser and unassigned @dcthomp

added 1 commit

• e3d22b23 - Update ci images to pick up paraview/smtk changes for autoload plugins

Compare with previous version

Warnings:

• the merge request is marked as a work-in-progress.

The warnings do not need to be fixed, but it is recommended to do so.

Hmm, seeing this error:

CMake Error at /root/misc/root/smtk-deps/lib/cmake/paraview-5.9/ParaViewPlugin.cmake:1433 (add_library):
  Cannot find source file:

    EXTRA_INCLUDES

  Tried extensions .c .C .c++ .cc .cpp .cxx .cu .mpp .m .M .mm .ixx .cppm .h
  .hh .h++ .hm .hpp .hxx .in .txx .f .F .for .f77 .f90 .f95 .f03 .hip .ispc
Call Stack (most recent call first):
  CMake/SMTKPluginMacros.cmake:119 (paraview_add_plugin)
  smtk/extension/paraview/appcomponents/plugin/CMakeLists.txt:142 (smtk_add_plugin)

I was thinking the directory should be paraview-5.10 ? stale files? stale image - linux has two more base images.

added 1 commit

• 65c8793f - Update ci images to pick up paraview/smtk changes for autoload plugins

Compare with previous version

Warnings:

• the merge request is marked as a work-in-progress.

The warnings do not need to be fixed, but it is recommended to do so.

I do not understand the mac build error. It is warning about including vtkPVConfig.h, which is clearly changed to vtkPVVersion.h in this MR, so what is happening?

resolved all threads

+1

resolved all threads

Do: merge

This merge request is marked as a Work in Progress and may not be merged. Please remove the Work in Progress state first.

marked this merge request as ready

Do: merge

mentioned in commit dcddd800

merged

mentioned in merge request cmb!805 (closed)

mentioned in issue #447 (closed)