Skip to content
Snippets Groups Projects

Small stuff

Merged David Thompson requested to merge dcthomp/smtk:small-stuff into master
1 unresolved thread

Some smaller fixes for SMTK, mostly from aeva.

Edited by David Thompson

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Errors:

    • commit 1821cc19 is not allowed because the following files are not formatted according to the 'clang-format' check: smtk/extension/qt/qtReferenceItem.cxx, smtk/view/Badge.h. Post a comment ending in the line Do: reformat to rewrite the MR source branch automatically.

    Warnings:

    • please consider adding a changelog entry in a file ending with .md in doc/release/notes.

    The warnings do not need to be fixed, but it is recommended to do so.

    Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.

  • Author Maintainer

    Do: reformat

  • This topic has been reformatted and pushed; please fetch from the source repository and reset your local branch to continue with further development on the reformatted commits.

  • Kitware Robot added 1 commit

    added 1 commit

    • 70b482b4 - Add support for default badges.

    Compare with previous version

  • Warnings:

    • please consider adding a changelog entry in a file ending with .md in doc/release/notes.

    The warnings do not need to be fixed, but it is recommended to do so.

  • David Thompson added 1 commit

    added 1 commit

    • 8a5b5879 - WIP: Bump CI images to new superbuild.

    Compare with previous version

  • David Thompson marked this merge request as draft from dcthomp/smtk@8a5b5879

    marked this merge request as draft from dcthomp/smtk@8a5b5879

  • Errors:

    • commit 8a5b5879 cannot be merged; it is marked as a work-in-progress (WIP).

    Warnings:

    • please consider adding a changelog entry in a file ending with .md in doc/release/notes.
    • the merge request is marked as a work-in-progress.

    The warnings do not need to be fixed, but it is recommended to do so.

    Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.

  • David Thompson added 1 commit

    added 1 commit

    • edae994d - Load the mesh-session plugin in this test.

    Compare with previous version

  • Errors:

    • commit 8a5b5879 cannot be merged; it is marked as a work-in-progress (WIP).

    Warnings:

    • please consider adding a changelog entry in a file ending with .md in doc/release/notes.
    • the merge request is marked as a work-in-progress.

    The warnings do not need to be fixed, but it is recommended to do so.

    Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.

35 35 pvsimple.LoadPlugin("$<TARGET_FILE:smtkPVServerExtPlugin>", True)
36 36 pvsimple.LoadPlugin("$<TARGET_FILE:smtkPQComponentsPlugin>", True)
37 37 pvsimple.LoadPlugin("$<TARGET_FILE:smtkPolygonSessionPlugin>", True)
38 pvsimple.LoadPlugin("$<TARGET_FILE:smtkMeshSessionPlugin>", True)
  • Author Maintainer

    @aron.helser FYI: You recently added wrapping for the mesh or mesh-session registrar... if your application uses ParaView, then loading this plugin is another way to accomplish registration without calling the registrar directly.

  • Please register or sign in to reply
  • David Thompson added 2 commits

    added 2 commits

    • 3c970b4e - Bump CI images to new superbuild.
    • 62493125 - Load the mesh-session plugin in this test.

    Compare with previous version

  • Warnings:

    • please consider adding a changelog entry in a file ending with .md in doc/release/notes.
    • the merge request is marked as a work-in-progress.

    The warnings do not need to be fixed, but it is recommended to do so.

  • David Thompson marked this merge request as ready

    marked this merge request as ready

  • LGTM, +1

  • Author Maintainer

    Do: merge

  • David Thompson mentioned in commit c11fa942

    mentioned in commit c11fa942

  • merged

  • Please register or sign in to reply
    Loading