Skip to content

ENH: qtAttributeItemInfo now stores a qtBaseAttributeView

Robert M. O'Bara requested to merge bob.obara/smtk:cleaningUpQtAttributeItemInfo into master

  • Added std::string ValueItem::valueLabel(ith) - convenience method to accede its definition’s valueLabel method

  • Changed to qtBaseAttributeView

    • CategoryTest was changed to take in a const attribute::ItemDefinitionPtr& instead of an attribute::ItemPtr since only the definition is needed. This also eliminated the construction/destruction of a shared pointer.
    • Added displayItemDefinition method which is similar to displayItem.
    • isItemWriteable now takes in a const attribute::ItemPtr & instead of a attribute::ItemPtr which eliminates the construction/destruction of a shared pointer.
    • advaceLevelTest now takes in a const attribute::ItemPtr & instead of a attribute::ItemPtr which eliminates the construction/destruction of a shared pointer.

  • qtAttributeInternal now stores a QPointer to a qtBaseAttributeView instead of a qtBaseView - this is more conceptually consistent and eliminated the need for dynamic casts.

  • Changes to qtAttributeItemInfo

    • Now stores a QPointer to a qtBaseAttributeView instead of a qtBaseView - this is more conceptually consistent and eliminated the need for dynamic casts.
    • Changed the API not to require it to be passed as a QPointer which was also unnecessary.

  • Changes to qtUIManager

    • Added the following methods that take into consideration the current text color (which changes based on the system’s theme):
      • correctedInvalidColor()
      • correctedDefaultColor()
      • correctedNormalColor()

Merge request reports