Skip to content

ENH: Update qtSelectorView and Cleaned up isValid Checks

Robert M. O'Bara requested to merge bob.obara/smtk:cleanupIsValidMethods into master

  • Passing an empty set of categories to Attribute::isValid or Item::isValid no longer means don't filter on categories. Instead the methods will always return false. If you don't want category filtering call the isValid methods that don't take in the set.

  • Item::isValid method that taken in categories is no longer virtual

  • A new virtual method Item::isValidInternal which performs the actual check has been added

  • Now properly works with Analysis categories

  • The view is considered empty if the selector item does not pass its category checks

  • Made the following methods const

    • displayItem
    • isItemWriteable
    • advanceLevel
    • categoryEnabled
    • currentCategory

  • Added a removeItems methods - this removes all of the qtItems from the qtAttribute and allows createBasicLayout to be called again

  • Added an option to createWidget that will allow a widget to be created even if the attribute's items are filtered out by categories and/or advanced level filtering.

  • Categories::passes method will no longer return true if the provided set of categories is empty. It will now return false.

Addresses Issues #323 (closed) and #324 (closed)

Merge request reports