ValueItemTemplate const_iterator typedef is incorrect?
template<typename DataT>
class SMTK_ALWAYS_EXPORT ValueItemTemplate : public ValueItem
{
//template<DataT> friend class ValueItemDefinitionTemplate;
public:
typedef DataT DataType;
typedef typename std::vector<DataT> value_type;
typedef value_type const_iterator;
typedef ValueItemDefinitionTemplate<DataType> DefType;
~ValueItemTemplate() override = default;
typename std::vector<DataT>::const_iterator begin() const { return m_values.begin(); }
typename std::vector<DataT>::const_iterator end() const { return m_values.end(); }
In the snippet above, should typedef value_type const_iterator;
actually be written as typedef typename value_type::const_iterator const_iterator;
?
If so, should the following begin()
and end()
functions be declared as:
const_iterator begin() const { return m_values.begin(); }
const_iterator end() const { return m_values.end(); }
???
Edited by jwilson1881