Investigate failure associated with fedora33-tidy:build
Observation
Starting with the integration of !2666 (merged) into master
, and also within !2665 (closed), the fedora33-tidy:build error seems unrelated and is associated with the file thirdparty/delaunay/Source/Mesh/Mesh.hh.
Notes
Worth noting that smtk does not build against the latest version, see history of Mesh.hh
here and overall history of the project here
Questions
Should it be fixed ?
It may be worth investigatin and why did the CI started to fail without having any update to files .gitlab?
Error
/builds/gitlab-kitware-sciviz-ci/thirdparty/delaunay/Source/Mesh/Mesh.hh:47:11: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
virtual ~Mesh() {}
^ ~~
= default;
/builds/gitlab-kitware-sciviz-ci/thirdparty/delaunay/Source/Mesh/Vertex.hh:39:11: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
virtual ~Vertex() {}
^ ~~
= default;
/builds/gitlab-kitware-sciviz-ci/thirdparty/delaunay/Source/Shape/Polygon.hh:42:3: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
~Polygon() {}
^ ~~
= default;
/builds/gitlab-kitware-sciviz-ci/thirdparty/delaunay/Source/Shape/Triangle.hh:37:3: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
~Triangle() {}
^ ~~
= default;