Investigate const& parameter typo possibilities
The following discussion from !2450 (merged) should be addressed:
-
@dcthomp started a discussion: (+2 comments) Changes to the API like this probably require a file in
doc/release/notes
noting the change, even if it won't affect many callers.Also, is there a reason to pass the shared-pointer by value instead of by const reference?
See commit 61d171ec for replacements.