Activity · CMB / Plugins / OpenFOAM Wave Tank

5 months ago

David Thompson @dcthomp

accepted merge request !18 "Changes for fedora + podman" at CMB / Plugins / OpenFOAM Wave Tank

5 months ago

David Thompson @dcthomp

pushed to branch master at CMB / Plugins / OpenFOAM Wave Tank

1b47defd · Merge branch 'fedora-fixes' into 'master'
... and 6 more commits. Compare f801d2ef...1b47defd

5 months ago

John Tourtellott @john.tourtellott

commented on merge request !18 "Changes for fedora + podman" at CMB / Plugins / OpenFOAM Wave Tank

+2...

5 months ago

Kitware Robot @kwrobot

commented on merge request !18 "Changes for fedora + podman" at CMB / Plugins / OpenFOAM Wave Tank

This topic has been reformatted and pushed; please fetch from the source repository and reset your local branch to continue with further developmen...

5 months ago

David Thompson @dcthomp

commented on merge request !18 "Changes for fedora + podman" at CMB / Plugins / OpenFOAM Wave Tank

Do: reformat

5 months ago

Kitware Robot @kwrobot

commented on merge request !18 "Changes for fedora + podman" at CMB / Plugins / OpenFOAM Wave Tank

Errors:...

5 months ago

John Tourtellott @john.tourtellott

commented on merge request !18 "Changes for fedora + podman" at CMB / Plugins / OpenFOAM Wave Tank

I think you want #ifndef here - with the n, so that it prints for Debug builds (when NDEBUG isn't defined).

5 months ago

David Thompson @dcthomp

approved merge request !18 "Changes for fedora + podman" at CMB / Plugins / OpenFOAM Wave Tank

5 months ago

David Thompson @dcthomp

commented on merge request !18 "Changes for fedora + podman" at CMB / Plugins / OpenFOAM Wave Tank

@john.tourtellott I've addressed your comments but also added more to the MR....

5 months ago

David Thompson @dcthomp

commented on merge request !18 "Changes for fedora + podman" at CMB / Plugins / OpenFOAM Wave Tank

Done.

5 months ago

David Thompson @dcthomp

commented on merge request !18 "Changes for fedora + podman" at CMB / Plugins / OpenFOAM Wave Tank

Derp. Thanks.

5 months ago

Kitware Robot @kwrobot

commented on merge request !18 "Changes for fedora + podman" at CMB / Plugins / OpenFOAM Wave Tank

This topic has been reformatted and pushed; please fetch from the source repository and reset your local branch to continue with further developmen...

5 months ago

David Thompson @dcthomp

commented on merge request !18 "Changes for fedora + podman" at CMB / Plugins / OpenFOAM Wave Tank

Do: reformat

5 months ago

Kitware Robot @kwrobot

commented on merge request !18 "Changes for fedora + podman" at CMB / Plugins / OpenFOAM Wave Tank

Errors:...

5 months ago

Kitware Robot @kwrobot

commented on merge request !18 "Changes for fedora + podman" at CMB / Plugins / OpenFOAM Wave Tank

Errors:...

6 months ago

John Tourtellott @john.tourtellott

commented on merge request !18 "Changes for fedora + podman" at CMB / Plugins / OpenFOAM Wave Tank

Empty #ifdef on lines 39-40. Recommend putting qInfo() on lines 37-38 inside #ifndef NDEBUG (debug build only)

6 months ago

John Tourtellott @john.tourtellott

commented on merge request !18 "Changes for fedora + podman" at CMB / Plugins / OpenFOAM Wave Tank

QString::contains() returns a boolean => please change L405 to...

6 months ago

Kitware Robot @kwrobot

commented on merge request !18 "Changes for fedora + podman" at CMB / Plugins / OpenFOAM Wave Tank

Errors:...

6 months ago

David Thompson @dcthomp

opened merge request !18 "Changes for fedora + podman" at CMB / Plugins / OpenFOAM Wave Tank

8 months ago

John Tourtellott @john.tourtellott

closed issue #2 "WEC Things To Do Jan 2024" at CMB / Plugins / OpenFOAM Wave Tank