ExternalProject: Retry download for error code 35
requested to merge xavisolesoft/cmake-carla:Enable-ExternalProject-download-retry-for-error-code-35 into master
This error code indicates a TLS handshake failure, which we've observed intermittently when downloading artifacts from GitHub.
Issue to fix
Sometimes, cmake FetchContent and ExternalProject downloads form github repo as .zip fail due the next error code:
status_code: 35
status_string: "SSL connect error"Download link example for flaky reproduction:
https://github.com/carla-simulator/StreetMap/archive/refs/heads/ue5.3.zipWhy the issue was happening
Cmake is not detecting internally error 35 as retriable, so retry policy is not applied and this causes the build to fail.
Why the issue should be fixed in cmake official version
Seems a common retriable error for github repo .zip download, so a lot off users my suffer it.
Topic-rename: ExternalProject-download-retry-for-error-code-35
Edited by Brad King