Skip to content
Snippets Groups Projects

LLVMFlang: Add support for targeting MSVC ABI on Windows

Merged Brad King requested to merge brad.king/cmake:LLVMFlang-MSVC into master

The compiler does not yet support everything needed to integrate well with the MSVC ABI, in particular for runtime library selection and debug format selection. Document them in FIXME comments and leave this support undocumented by CMake for now.

Fixes: #24840 (closed)
Inspired-by: @pbo-linaro
Backport: release
Supersedes: !8776 (closed)

Edited by Brad King

Merge request reports

Merge request pipeline #369160 waiting for manual action

Merge request pipeline waiting for manual action for 26bf32cd

Approval is optional

Merged by Kitware RobotKitware Robot 1 year ago (Oct 4, 2023 3:18pm UTC)

Merge details

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • We should resolve the open discussions before merging this, but meanwhile I'll stage this to see how the changes do in nightly testing.

    Do: stage

  • Brad King added 6 commits

    added 6 commits

    • 12733d0d - CMakeParseImplicitLinkInfo: Detect link lines using link.exe and lld-link
    • 7571e653 - CMakeDetermineCompilerABI: Add option to skip implicit link info parsing
    • 9d060b86 - Fortran: Save CMAKE_LINKER variable persistently for MSVC ABI
    • 26fa048f - Tests: Enable CMP0091/CMP0141 for MSVC settings in FortranOnly test
    • e9af7b96 - LLVMFlang: Add support for CMAKE_Fortran_COMPILER_TARGET
    • b9d70abc - LLVMFlang: Add support for targeting MSVC ABI on Windows

    Compare with previous version

  • Do: stage

  • Brad King added 1 commit

    added 1 commit

    • 26bf32cd - LLVMFlang: Add support for targeting MSVC ABI on Windows

    Compare with previous version

  • Do: stage

  • Brad King resolved all threads

    resolved all threads

  • Brad King changed the description

    changed the description

  • removed triage:blocked label

  • Warnings:

    • Eligible for the 3.28.x branch.

    The warnings do not need to be fixed, but it is recommended to do so.

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading