GNUtoMS: Add search path for VS 2015 environment scripts

Change is necessary to bring back cmake_add_fortran_subdirectory functionality to Visual Studio 2017 (and possibly 2015, which I never got to work historically). It definitely works now with this path change in the platform file.

Topic-rename: vs14-GNUtoMS

Errors:

• commit 8cc60d1e has an invalid commit subject; the first line must be no longer than 78 characters.

Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.

added 1 commit

• 58d701df - Added missing path which was necessary for CMake_add_fortran_subdirectory

Compare with previous version

Errors:

• commit 58d701df has an invalid commit subject; the second line must be empty.
• commit 58d701df has an invalid commit subject; it cannot be exactly two lines.

Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.

added 1 commit

• 66c8e569 - Added missing VS path necessary for CMake_add_fortran_subdirectory

Compare with previous version

added comp:gcc os:windows labels

Thanks. This looks correct for VS 2015, but I don't think it will work with VS 2017 installed without any VS 2015 available. VS 2017 does not set any of these registry entries. Instead we need to query Visual Studio Installer as we do in InstallRequiredSystemLibraries. I'm not sure whether the existing query is sufficient or a new one needs to be added on the C++ side.

added workflow:wip label

I don't currently have VS 2015 itself installed, but I did once upon a time. It may have left behind some pieces that enabled this to work for me with 2017.

I do have the 2015 redistributable still installed.

I can say that the VS2015 /14.0 registry entry was still present on my system. Reading it seems to be sufficient, however, despite the lack of a full VS 2015 install.

changed title from Added missing path to Windows-Gnu.cmake platform file to GNUtoMS: Add search path for VS 2015 environment scripts

added 1 commit

• c02d4d2a - GNUtoMS: Add search path for VS 2015 environment scripts

Compare with previous version

added triage:env-regression label

assigned to @brad.king

changed milestone to %3.8.2

Warnings:

• Eligible for the 3.8.x branch.

The warnings do not need to be fixed, but it is recommended to do so.

Either way this is a good fix on its own. I've updated your branch to revise the commit message and rebase back for 3.8.

Do: stage

added workflow:nightly-testing and removed workflow:wip labels

Just ran a test on a clean machine and I can confirm this doesn't work on VS2017 without having had a previous VS2015 on the system.

I'll start working on a clean VS 2017 install solution as per your example above. Would you like that pushed to the same merge request, or a new one created for that effort?

@avacar thanks. Please open a new MR for the VS2017 work, once again based on master, perhaps after this MR has been merged.

I've got the correct fix working for VS 2017 now. I did not need to change the cxx code to do it. I'll hold off on the MR until I see this MR close. Then I'll upstream pull, branch, and MR the additional change.