Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • CMake CMake
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 4.2k
    • Issues 4.2k
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 9
    • Merge requests 9
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • External wiki
    • External wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

Admin message

A Gitlab update will be applied on June 5th , between 6PM - 7PM EDT (UTC-04:00). This site may have intermittent delays during that time.

  • CMakeCMake
  • CMakeCMake
  • Merge requests
  • !7820

CPack/NSIS: Document BOM for licence encoded in UTF-8

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Mojca Miklavec requested to merge mojca/cmake:nsis-licence-bom into master Oct 24, 2022
  • Overview 5
  • Commits 1
  • Pipelines 2
  • Changes 1

The only hint that the file needs to have a BOM mark is included in release notes:

  • https://cmake.org/cmake/help/latest/release/3.20.html#cpack

It would make a lot more sense to document this next to the option name. (I first wanted to file a feature request to support UTF-8.)

Backport: release

Edited Oct 24, 2022 by Brad King
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: nsis-licence-bom