ctest: only report make-level errors when no others are found

In !5266 (merged) we taught CTest to capture and report errors from the build command when using launchers.

This had the unintended side effect of reporting a separate build error containing the full build output when the build command returns non-zero. To fix this problem, we now only report build command errors from CTest launchers when no other more specific build errors are found.

Fixes: #23991 (closed)
Backport: release

added area:ctest label

@zackgalbreath please check the commit referenced in the description. It doesn't seem to exist.

added workflow:in-review label

changed milestone to %3.25.0

assigned to @brad.king

added 1 commit

• 0e695247 - ctest: only report make-level errors when no others are found

Compare with previous version

changed the description

resolved all threads

changed the description

added 1 commit

• c85c0434 - ctest: only report make-level errors when no others are found

Compare with previous version

Do: stage

added workflow:nightly-testing label and removed workflow:in-review label

@brad.king and @zackgalbreath,

Any chance this can be backported to 3.24 and go out in the next patch release 3.24.3? That would speed up the process for getting this fixed and deployed at SNL.

This is clearly a defect and therefore should be okay to put out in a patch release of 3.24.z as per:

• https://semver.org/#spec-item-6

which says:

6. Patch version Z (x.y.Z | x > 0) MUST be incremented if only backwards compatible bug fixes are introduced. A bug fix is defined as an internal change that fixes incorrect behavior.

added 3 commits

• c85c0434...e7fd69fa - 2 commits from branch cmake:master
• 65260d6c - ctest: only report make-level errors when no others are found

Compare with previous version

changed the description

Warnings:

• Eligible for the 3.24.x branch.

The warnings do not need to be fixed, but it is recommended to do so.

added triage:regression workflow:in-review labels and removed workflow:nightly-testing label

Do: stage

added workflow:nightly-testing label and removed workflow:in-review label