Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • CMake CMake
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,924
    • Issues 3,924
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 16
    • Merge requests 16
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • External wiki
    • External wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • CMake
  • CMakeCMake
  • Merge requests
  • !7443

genex-LINK_LIBRARY: ensure correct generation inside LINK_GROUP genex

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Marc Chevrier requested to merge marc.chevrier/cmake:genex-LINK_LIBRARY-fix-generation into master Jul 03, 2022
  • Overview 5
  • Commits 1
  • Pipelines 3
  • Changes 5

This fix ensures the following pattern is correctly handled:

$<LINK_GROUP:group_feat,$<LINK_LIBRARY:lib_feat,mylib>>

With:

CMAKE_LINK_GROUP_USING_group_feat = "—START_GROUP" "—END_GROUP"  
CMAKE_LINK_LIBRARY_USING_lib_feat = "—PREFIX" "—LINK <LIBRARY>" "—SUFFIX"

Before the fix, we get the following generation:

—START_GROUP —PREFIX —LINK /path/to/mylib —END_GROUP —SUFFIX

—END_GROUP and —SUFFIX are in the wrong order

After the fix, we get the correct order:

—START_GROUP —PREFIX —LINK /path/to/mylib —SUFFIX —END_GROUP

Backport: release

Edited Jul 05, 2022 by Brad King
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: genex-LINK_LIBRARY-fix-generation