Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • CMake CMake
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,928
    • Issues 3,928
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 19
    • Merge requests 19
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • External wiki
    • External wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • CMake
  • CMakeCMake
  • Merge requests
  • !7419

AUTOUIC: Fix internal paths of generated ui_foo.h files

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Jörg Bornemann requested to merge jobor/cmake:fix-23523 into master Jun 28, 2022
  • Overview 4
  • Commits 1
  • Pipelines 2
  • Changes 1

For every file foo.ui we generate a ui_foo.h file in ${target}_autogen/include or ${target}autogen/include$ in the multi-config case. Even .ui files in subdirectories are handled this way. That means, .ui files with the same base name will conflict in a target.

However, for .ui files in subdirectories we added generated sources with the nonexistent path ${target}_autogen/include/subdir/ui_foo.h. This patch fixes that.

Also, CMake will now yield an error if a target has multiple .ui files with the same base name.

Fixes: #23523
Backport: release

Edited Jun 28, 2022 by Brad King
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: fix-23523