Source: Replace uses of sprintf with safer snprintf

assigned to @brad.king

added workflow:in-review label

changed milestone to %3.25.0

Do: stage

added workflow:nightly-testing label and removed workflow:in-review label

RunCMake.get_filename_component is failing in master for me, so not related to my changes.

@brad.king there are also sprintf in cmake/Source/CursesDialog/form/fty_int.c, but that looks like 3rd party code, but I could not find where upstream is...

Where do you see it failing at all?

Don't worry about curses form upstream.

Where do you see it failing at all?

Oh, I thought that was the test failing on CI, but it's a different one. It fails on my Mac.

Don't worry about curses form upstream.

macOS 13 Ventura now warns about sprintf() (as does OpenBSD), I've disabled the warning for now, but would like to bring it back...

I meant that we can just go ahead and fix the warning in our copy of curses form. I've updated your branch to do this.

changed title from Replaced uses of sprintf with safer snprintf to Source: Replace uses of sprintf with safer snprintf

added 1 commit

• 2f81f6b1 - Source: Replace uses of sprintf with safer snprintf

Compare with previous version

added workflow:in-review label and removed workflow:nightly-testing label

added 2 commits

• eccd0b92 - Source: Tell Git not to check whitespace in third-party curses form code
• d5694e46 - Source: Replace uses of sprintf with safer snprintf

Compare with previous version

Do: stage

added workflow:nightly-testing label and removed workflow:in-review label

Do: merge

mentioned in commit b865fead

merged

removed workflow:nightly-testing label