Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • CMake CMake
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 4.2k
    • Issues 4.2k
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 10
    • Merge requests 10
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • External wiki
    • External wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • CMakeCMake
  • CMakeCMake
  • Merge requests
  • !7096

CPack/NSIS: Fix uninstall command when run from installer

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Marc Jeanmougin requested to merge mc/cmake:nsis-fix-uninstall-quoting into master Mar 21, 2022
  • Overview 6
  • Commits 2
  • Pipelines 4
  • Changes 1

The quoting of path introduced in !6517 (merged) created two errors in the uninstaller call: double quoting of the uninstaller executable, and quotes added to the _?= argument which does not support them. This fix simplifies the command

This fix slightly changes the behavior, in the sense that the uninstaller will now copy itself to the temporary directory when run, to greatly simplify the NSIS code here, which I don't think has any significant negative effect. Another fix keeping the _?= would have added a char to the existing StrLen command (to get rid of the ending quote) and adding a start offset of 1 to the StrCpy to get rid of the leading quote.

Backport: release
Topic-rename: cpack-nsis-fix-uninstall-quoting

Edited Mar 21, 2022 by Brad King
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: nsis-fix-uninstall-quoting