Unify the commandline length limit logic

As a followup to !633 (merged) , this patch would unify the commandline length logic from the Makefile and Ninja generators, ensuring consistent behavior across all generators.

Errors:

• commit 437d1d2a is not allowed because the following files are not formatted according to the 'clang-format' check: Source/cmNinjaNormalTargetGenerator.cxx, Source/cmSystemTools.cxx. Use Do: reformat to rewrite the MR source branch automatically.

Warnings:

• The given name (ChrisTX) for commit 437d1d2a has no space in it. A full name is preferred for contribution. Please set the user.name Git configuration value.

The warnings do not need to be fixed, but it is recommended to do so.

Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.

added 1 commit

• 4cc34a70 - Unify the commandline length logic

Compare with previous version

Errors:

• commit 4cc34a70 is not allowed because the following files are not formatted according to the 'clang-format' check: Source/cmNinjaNormalTargetGenerator.cxx, Source/cmSystemTools.cxx. Use Do: reformat to rewrite the MR source branch automatically.

Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.

Do: reformat

This topic has been reformatted and pushed; please fetch from the repository before further development to use the new topic locally.

added 1 commit

• 1f56435e - Unify the commandline length logic

Compare with previous version

added 1 commit

• 1b033bdd - Unify command line length logic

Compare with previous version

Errors:

• commit 1b033bdd is not allowed because the following files are not formatted according to the 'clang-format' check: Source/cmNinjaNormalTargetGenerator.cxx, Source/cmSystemTools.cxx. Use Do: reformat to rewrite the MR source branch automatically.

Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.

Do: reformat

This topic has been reformatted and pushed; please fetch from the repository before further development to use the new topic locally.

added 1 commit

• 73a2c369 - Unify command line length logic

Compare with previous version

added workflow:wip label

I've noticed that MSYS patches the response file behavior of CMake downstream by disabling it altogether for the "MSYS Makefiles" generator, see https://github.com/Alexpux/MINGW-packages/blob/master/mingw-w64-cmake/0001-Disable-response-files-for-MSYS-Generator.patch . This is genuinely confusing as some packages will exceed the limit on Windows and simply won't compile with "MSYS Makefiles", but will build with "Unix Makefiles" when called from MSYS unless that CMAKE_NEED_RESPONSE variable they've introduced is set (I ran into this while attempting to build OpenBLAS on the weekend, for example).

Under the current behavior, CMake has no limits defined for Windows in the Makefile generators, since sysconf doesn't exist there and the 8000 character limit only applied to Ninja, so I suspect the logic behind forcing the generator to always use Makefiles in the platform script stems from this oversight. Namely, under MSYS, the link and compile lines will never be visible due to the excessive usage of response files.

Unless there's something in specific that I'm missing, the forced usage of response could be removed from Windows-GNU.cmake once the command line length can be properly determined in the Makefile generators on Windows.

added 1 commit

• 1f139880 - Unify command line length logic

Compare with previous version

resolved all discussions

mentioned in issue #16771

the forced usage of response could be removed from Windows-GNU.cmake

Yes, this would be nice to do. PTAL at cmMakefileTargetGenerator::CheckUseResponseFileForLibraries and cmMakefileTargetGenerator::AddIncludeFlags which I think would need updates for that. Currently they don't check any limit.