Skip to content

GoogleTest: Fix type param tests and update their format

Evgeniy Shcherbina requested to merge ixsci/cmake:GoogleTest-discover-type-params into master

The fix is for the situation where a typed suite has 10+ types to work with. So before the fix having the following input:

TypedSuite/1.  # TypeParam = int
  case
TypedSuite/10.  # TypeParam = char
  case

It would produce the following output:

TypedSuite/int.case
TypedSuite/10.  # TypeParam = char.case

And the fixed version produces:

TypedSuite/int.case
TypedSuite/char.case

Then the format of the test line output has been changed to match the one used elsewhere (value & simple tests). So instead of TypedSuite/int.case it would be TypedSuite.case<int> (if NO_PRETTY_TYPES is specified then the test number, from gtest output, would be used instead TypedSuite.case<0>). It differs from the format I suggested in #23057 (closed) but after some thought I decided that having angle brackets helps to recognize a typed test at a glance.

Fixes: #23057 (closed)
Backport: release

Edited by Brad King

Merge request reports