Skip to content
Snippets Groups Projects

CompilerId: Fix default extensions check for Clang targeting MSVC ABI

Merged Brad King requested to merge brad.king/cmake:default-extensions into master

In !6177 (merged), extensions were assumed to be OFF for Clang targeting the MSVC ABI. However, the clang and clang++ tools both seem to have extensions enabled by default even when targeting the MSVC ABI.

This can be observed with the RunCMake.CompileFeatures test. It fails with the GNU-like clang/clang++ front-end, but removing the above special case makes it pass. The test passes either way with the MSVC-like clang-cl front-end.

Backport: release

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading