Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • CMake CMake
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,924
    • Issues 3,924
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 17
    • Merge requests 17
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • External wiki
    • External wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • CMake
  • CMakeCMake
  • Merge requests
  • !6949

CompilerId: Fix default extensions check for Clang targeting MSVC ABI

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Brad King requested to merge brad.king/cmake:default-extensions into master Feb 03, 2022
  • Overview 12
  • Commits 1
  • Pipelines 2
  • Changes 3

In !6177 (merged), extensions were assumed to be OFF for Clang targeting the MSVC ABI. However, the clang and clang++ tools both seem to have extensions enabled by default even when targeting the MSVC ABI.

This can be observed with the RunCMake.CompileFeatures test. It fails with the GNU-like clang/clang++ front-end, but removing the above special case makes it pass. The test passes either way with the MSVC-like clang-cl front-end.

Backport: release

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: default-extensions