Skip to content

Fix ASM_NASM static library link failure with MSVC

Francesco Bertolaccini requested to merge frabert/cmake:master into master

On Windows using MSVC, a simple project such as this one:

cmake_minimum_required(VERSION 3.16.0)

project(test VERSION 1.0.0 LANGUAGES C CXX ASM_NASM)

add_library(test STATIC test.asm)

fails to link because during the linking step link.exe is called with GNU-style arguments. This MR proposes a fix which involves falling back on the options used for C or CXX static library linking, if present, instead of GNU-style arguments.

Merge request reports