Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • CMake CMake
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,926
    • Issues 3,926
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 18
    • Merge requests 18
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • External wiki
    • External wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • CMake
  • CMakeCMake
  • Merge requests
  • !5084

GoogleTest: Restore support for list arguments in TEST_EXECUTOR

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged lauritsriple requested to merge lauritsriple/cmake:support_list_google_test_executor into master Jul 30, 2020
  • Overview 4
  • Commits 1
  • Pipelines 2
  • Changes 1

Refactoring in !4078 (merged) accidentally parsed TEST_EXECUTOR as a single-value argument instead of a list.

The CMAKE_CROSSCOMPILING_EMULATOR supports a semicolon-separated list (docs). In googletest this is sent to TEST_EXECUTOR which does not currently support semicolon-separated list so only the first element in the list is assigned to TEST_EXECUTOR resulting in missing arguments to the command.

Backport: release

Edited Aug 06, 2020 by Brad King
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: support_list_google_test_executor