Skip to content

cmPropertyDefinition: simplify name and scope handling

Tushar Maheshwari requested to merge tusharpm/cmake:simplify_cmPropertyDefinitionMap into master
  • Remove the Name and Scope members from cmPropertyDefinition, as they aren't accessed.
  • Modify cmPropertyDefinitionMap to use the name and scope as key.
    • Change from inheritance to composition of the std::map and change access to private.
    • Make the necessary adjustments in cmState to use the new interface.
    • Remove the unused IsPropertyDefined method.
    • Inline the IsPropertyChained method.
    • Move the cmPropertyDefinitionMap to the same files as cmPropertyDefinition and remove cmPropertyDefinitionMap.{cxx,h}.

Tested build with ./bootstrap and cmake --build . using Ninja generator.

Merge request reports