Skip to content

Refactor cmMakefile::AddDefinition to accept the value argument as cm:string_view

Sebastian Holtermann requested to merge sebholt/cmake:definitions_string_view into master

Refactors cmDefinitions and cmMakefile to accept a cm::string_view instead of const char * for definition value arguments.

  • Refactors cmDefinitions::Set to accept the value argument as cm::string_view
  • Adds cmDefinitions::Unset (to be used instead of cmDefinitions::Set(key, nullptr))
  • Refactors cmMakefile::AddDefinition to accept the value argument as cm::string_view
  • Removes c_str() calls when cmDefinitions::Set or cmMakefile::AddDefinition is called with a std::string argument.

Merge request reports