Skip to content
Snippets Groups Projects

Help: Document the expire and external discussion resolve states

Merged Craig Scott requested to merge craig.scott/cmake:doc-mr-resolve-states into master
All threads resolved!

Our practice of closing MRs temporarily while discussion takes place in a separate issue isn't always well understood by MR authors. Expiring a MR seems to be better understood, but making it clear that it is also a temporary state is helpful.

Merge request reports

Pipeline #138103 passed

Pipeline passed for 49f5b6f7 on craig.scott:doc-mr-resolve-states

Approval is optional

Merged by Kitware RobotKitware Robot 5 years ago (May 30, 2019 2:09pm UTC)

Merge details

  • Changes merged into master with 5bb1e9a3.
  • Deleted the source branch.

Pipeline #138115 passed

Pipeline passed for 5bb1e9a3 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Craig Scott added 1 commit

    added 1 commit

    • 9984d252 - Help: Document the expire and external discussion resolve states

    Compare with previous version

  • Craig Scott added 1 commit

    added 1 commit

    • beddcdd2 - Help: Document the expire and external discussion resolve states

    Compare with previous version

    • Author Maintainer
      Resolved by Brad King

      I ended up not creating a separate "Temporary" section under "Resolve", but instead I added an explanatory paragraph at the start of the "Resolve" section. I'm happy to rework it to add a separate "Temporary" subsection (or similar) as per your initial suggestion though if you think that would work better than what's here now.

  • Brad King added workflow:wip label and removed workflow:in-review label

    added workflow:wip label and removed workflow:in-review label

  • Craig Scott added 1 commit

    added 1 commit

    • 49f5b6f7 - Help: Document the expire and external discussion resolve states

    Compare with previous version

  • Author Maintainer

    @ben.boeckel @brad.king Ready for another look.

  • Ben Boeckel resolved all discussions

    resolved all discussions

  • added workflow:in-review label and removed workflow:wip label

  • +1

    Do: merge

  • Brad King mentioned in commit 5bb1e9a3

    mentioned in commit 5bb1e9a3

  • merged

  • Please register or sign in to reply
    Loading