Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • CMake CMake
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 4,166
    • Issues 4,166
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • External wiki
    • External wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • CMakeCMake
  • CMakeCMake
  • Merge requests
  • !3205

cmake-gui: Fix theme on Windows with Qt >= 5.10

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged mistersandman requested to merge mistersandman/cmake:gui_theme_window_fix into master Apr 08, 2019
  • Overview 6
  • Commits 3
  • Pipelines 4
  • Changes 3

The QWindowsVistaStyle moved into a separate plugin in Qt 5.10 (see https://code.qt.io/cgit/qt/qtbase.git/commit/?id=4f3249f32dbe5c20aabbfd9b4f9c558aaf449e48).

We need to link explicitly against this plugin now after updating to Qt 5.12 (!3079 (merged)).

Note: There might be other missing libraries to link against in win32_release.cmake and win64_release.cmake, but I can't test this, since the specific Qt configurations for the release builds are not public (#19103 (closed)).

Fixes: #19147 (closed)
Topic-rename: cmake-gui-windows-theme

Edited Apr 08, 2019 by Brad King
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: gui_theme_window_fix