Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • CMake CMake
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 4,165
    • Issues 4,165
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 13
    • Merge requests 13
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • External wiki
    • External wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • CMakeCMake
  • CMakeCMake
  • Merge requests
  • !2897

FindLAPACK: Distinguish check result variable name from FindBLAS

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Brad King requested to merge brad.king/cmake:FindLAPACK-typo into master Jan 31, 2019
  • Overview 3
  • Commits 3
  • Pipelines 3
  • Changes 2

Since commit 192a9182, FindLAPACK accidentally used FindBLAS's BLAS_ prefix for some of its check results.

Since !2312 (merged), FindBLAS stores a check result in a plain BLAS_WORKS variable. The typo in FindLAPACK happens to cause a collision with that name.

The typo was already fixed in post-3.13 development as part of other work in !2633 (merged). Fix the typo in the 3.13 version of FindLAPACK to avoid the collision. Otherwise it could cause FindLAPACK to incorrectly determine that a certain library combination does not work (or incrrectly that it works).

Fixes: #18860 (closed)

Edited Jan 31, 2019 by Brad King
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: FindLAPACK-typo