Skip to content

Prevent pre-existing 'cmd' variable from tripping up ExternalProject_Add

Karsten Sperling requested to merge ksperling/cmake:external-project-cmd-poisoning into master

When using ExternalCommand_Add with no explicit BUILD and INSTALL command, it will erroneously pick up the value of a pre-existing cmd variable for both those commands. This is caused by _ep_get_build_command reading its output variable and only doing its job when it is not already set. However all of the call sites leave the output variable uninitialized and expect it to be set unconditionally.

Merge request reports