Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
CMake
CMake
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,298
    • Issues 3,298
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 10
    • Merge Requests 10
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • External Wiki
    • External Wiki
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • CMake
  • CMakeCMake
  • Merge Requests
  • !2424

Merged
Created Sep 30, 2018 by Mateusz Zych@mtezychContributor

Respect CMAKE_RC_COMPILER & CMAKE_MT in vs_link_dll/exe

  • Overview 46
  • Commits 5
  • Pipelines 8
  • Changes 10

CMake commands vs_link_dll and vs_link_exe, performing linking on MSVC,
are responsible for calling resource compiler and manifest tool.

Before this commit, both of these tools were called directly,
with the expectation that they are available via PATH mechanism.
This incorrect behavior has been fixed by respecting CMake Cache variables
CMAKE_RC_COMPILER and CMAKE_MT defining paths to these tools.

Fixes: #17804 (closed)
Topic-rename: msvc-custom-rc-mt

Edited Oct 09, 2018 by Brad King
Assignee
Assign to
Reviewer
Request review from
3.14.0
Milestone
3.14.0 (Past due)
Assign milestone
Time tracking
Source branch: master