Skip to content
Snippets Groups Projects

Help: Clarify cmake_host_system_information memory units

All threads resolved!

The memory size query implementations report in units of one mebibyte (2^20). Clarify the unit in the documentation because "megabyte" might also be interpreted as 10^6.

One mebibyte is 1024 * 1024 One megabyte is 1000 * 1000

Various lines at https://gitlab.kitware.com/cmake/cmake/blob/master/Source/kwsys/SystemInformation.cxx

And the line in the kernel at https://github.com/torvalds/linux/blob/360bd62dc4943a0754e6cb5637e01b5b43143cfc/fs/proc/meminfo.c#L30

Indicate the use of 1024 instead of 1000 when calculating the sizes.

Edited by Brad King

Merge request reports

Approval is optional

Merged by avatar (Apr 13, 2025 2:02am UTC)

Merge details

  • Changes merged into master with 228a2b0d.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Let's unstage this until the discussion is resolved.

    Do: unstage

  • added 1 commit

    • a4e6e156 - Help: Added footnote to memory units in cmake_host_system_information

    Compare with previous version

  • added 1 commit

    • 5f96627f - Help: Fixed RST syntax errors in cmake_host_system_information

    Compare with previous version

  • Craig Scott added 1 commit

    added 1 commit

    • 228a2b0d - Help: Clarify cmake_host_system_information memory units

    Compare with previous version

  • @tay10r Thanks, I squashed your fixup commits. Looks good for nightly testing now.

    Do: stage

  • Craig Scott resolved all discussions

    resolved all discussions

  • Do: merge

  • Craig Scott mentioned in commit 151fc668

    mentioned in commit 151fc668

  • merged

  • Please register or sign in to reply
    Loading