Skip to content
Snippets Groups Projects

file(GLOB): Ensure entire file list is sorted

Merged Shane Parris requested to merge slp091020/cmake:sort_glob_output into master

Previously, the file list produced by file(GLOB) commands would not have been sorted in its entirety if multiple globbing expressions were given. Moving the sort operation will fix it.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Shane Parris added 1 commit

    added 1 commit

    • 8d7d12fe - file(GLOB): Ensure entire file list is sorted

    Compare with previous version

  • Shane Parris added 1 commit

    added 1 commit

    • cc9e72c4 - Add test for sorting and deduping of file(GLOB) result

    Compare with previous version

  • Shane Parris resolved all discussions

    resolved all discussions

  • assigned to @brad.king

  • Brad King changed milestone to %3.12.0

    changed milestone to %3.12.0

  • added workflow:in-review and removed workflow:wip labels

  • Do: test

  • This merge request has been queued for testing. Test results may be viewed on:

    • CDash (master)
    • Buildbot (master) (only visible from inside Kitware)

    Branch-at-master: cc9e72c4

  • Shane Parris added 2 commits

    added 2 commits

    • b688d4fd - file(GLOB): Ensure entire file list is sorted
    • 87a6816b - Add test for sorting and deduping of file(GLOB) result

    Compare with previous version

  • Author Contributor

    Changed to .begin() and .end() instead of the std:: variants. Should get rid of the IWYU warning.

  • Great, thanks.

    Do: stage

  • Do: merge

  • Brad King mentioned in commit f8adde15

    mentioned in commit f8adde15

  • merged

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading