GenericSystem: Remove misspelled flag default
In CMakeGenericSystem, it should be CMAKE_INCLUDE_SEP_<LANG>
and not
CMAKE_INCLUDE_<LANG>_SEP
. However, if the flag is defined, include
behavior changes to Java-style non-repeating flags, which isn't
intended. Therefore, removing the (misspelled) default initialization
should help remove confusion and unintended side effects.
Topic-rename: generic-inc-sep-typo-remove
Merge request reports
Activity
added workflow:nightly-testing label
added workflow:wip and removed workflow:nightly-testing labels
@brad.king I just thought the flag was misspelled - turns out, if it's defined at at all, it will cause CMake to stop repeating
-I
flags and just use Java-style-classpath
syntax. It's probably best to remove the default altogether then.added workflow:nightly-testing label
removed workflow:wip label
- Resolved by Christian Pfeiffer
Yes, removing makes sense. Please revise the commit message and MR description accordingly.
added 1 commit
- cd3e1600 - GenericSystem: Remove misspelled flag default
removed workflow:nightly-testing label
mentioned in commit 52573b32