VS: Update support for LLVM-vs* toolsets from LLVM 5.0

Revert !131 (merged). Since at least LLVM 5.0 the VS integration of the LLVM toolchain now mimics cl and accepts MSVC-style command-line arguments (unlike Microsoft Clang/C2).

Fixes: #17193 (closed), #17235 (closed)
Topic-rename: vs-clang-llvm-support

Errors:

• commit 667201bd has an invalid commit subject; the first line must be no longer than 78 characters.

Warnings:

• The given name (SSE4) for commit 667201bd has no space in it. A full name is preferred for contribution. Please set the user.name Git configuration value.

The warnings do not need to be fixed, but it is recommended to do so.

Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.

added 1 commit

• 646c6f00 - do not pass invalid GCC-style invalid arguments to LLVM toolchain

Compare with previous version

Errors:

• commit 646c6f00 has an invalid commit subject; the second line must be empty.
• commit 646c6f00 has an invalid commit subject; it cannot be exactly two lines.

Warnings:

• The given name (SSE4) for commit 646c6f00 has no space in it. A full name is preferred for contribution. Please set the user.name Git configuration value.

The warnings do not need to be fixed, but it is recommended to do so.

Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.

added 1 commit

• 4ff6dbed - Windows-MSVC: do not pass invalid arguments to LLVM toolchain

Compare with previous version

changed title from - do not pass invalid GCC-style invalid arguments to LLVM toolchain, which is… to Windows-MSVC: do not pass invalid arguments to LLVM toolchain

changed the description

changed the description

This essentially reverts !131 (merged). @Roman80 can you explain why that change was made? Has LLVM/Clang's VS integration changed the command-line tool it uses underneath since then?

changed title from Windows-MSVC: do not pass invalid arguments to LLVM toolchain to {+VS: Fix support for LLVM-vs toolsets from LLVM 5.0+}*

changed the description

added comp:clang gen:vs labels

changed milestone to %3.10.0

assigned to @brad.king

added 79 commits

• 4ff6dbed...d4f58a9c - 78 commits from branch cmake:master
• 0b1ff7a1 - VS: Fix support for LLVM-vs* toolsets from LLVM 5.0

Compare with previous version

changed title from VS: Fix support for LLVM-vs toolsets from LLVM 5.0* to VS: Update support for LLVM-vs toolsets from LLVM 5.0*

added 1 commit

• 8a4755ca - VS: Update support for LLVM-vs* toolsets from LLVM 5.0

Compare with previous version

@SSE4 I updated your branch to make it a full revert of !131 (merged) and revised the commit message with an explanation. Please fetch and reset your checkout.

Do: stage

added workflow:nightly-testing label

mentioned in issue #17193 (closed)

Do: merge

removed workflow:nightly-testing label

mentioned in commit 3ea87bce

merged

mentioned in issue #16439 (closed)