CPack: NSIS.template.in defines INST_DIR but that may be a typo
The NSIS.template.in
file contains the following lines near the top:
; You must define these values
!define VERSION "@CPACK_PACKAGE_VERSION@"
!define PATCH "@CPACK_PACKAGE_VERSION_PATCH@"
!define INST_DIR "@CPACK_TEMPORARY_DIRECTORY@"
There's no explanation for why these must be defined, and in particular I cannot find any further reference to INST_DIR
. The file uses $INSTDIR
in many places, but I don't know if that is the same thing, or just a coincidentally similar name for something else (possibly install-time versus package creation time, but I am not sufficiently familiar with the NSIS logic to know). Either way, the purpose of the variable should be determined and the comment updated so that it is clear what INST_DIR
is used for, other whether it is indeed a typo. The VERSION
and PATCH
variables seem clear enough, but I haven't looked any further at those.