CTest: provide more consistent universal default test timeout
I opened !8239 (closed) and this is to have a design discussion that came to light via documenting existing behavior.
I would like to change CMake/CTest:
-
CTEST_TEST_TIMEOUT
take effect in CMakeLists.txt and any form ofctest
invocation where something else doesn't override it. - Make one timeout for
include(CTest)
andenable_testing()
. Right now they are 1500 seconds and 1000000 seconds respectively, which is confusing for long-running individual tests and wasn't documented anywhere. I think the arbitrarily large 1000000 seconds is fine.
From Brad King:
Ideally we should avoid promoting the ancient legacy name
DART_TESTING_TIMEOUT
. Its role is to become theTimeOut
field in the legacyDartConfiguration.tcl
config file in the build tree. This is used for command-line invocations ofctest -M Experimental -T Test
and similar. We need to preserve a reasonable default timeout for the command-line driver, and a way to set it. In CTest scripts,ctest_test
uses the value as a fallback ifCTEST_TEST_TIMEOUT
is not set.