CPackIFW: Problems settings icons since commit 761b6e24
!6613 (merged) introduces a feature to prevent name collisions. In order to do that, the function GetFilenameLastExtension is used to returns the file extension, including the ".". The committed code thus generates a filename with two dots ("cm_appicon..ico" instead of "cm_app.ico".)
The relevant piece of code can be seen below.
std::string srcName =
cmSystemTools::GetFilenameName(this->InstallerApplicationIcon);
std::string suffix = cmSystemTools::GetFilenameLastExtension(srcName);
std::string name = "cm_appicon." + suffix;
Changing
std::string name = "cm_appicon." + suffix;
to
std::string name = "cm_appicon" + suffix;
fixes the issue.
Before submitting a patch, I would appreciate if someone else could confirm the original behavior is indeed incorrect.
Thanks
Edited by Brad King