Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
CMake
CMake
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,297
    • Issues 3,297
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 9
    • Merge Requests 9
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • External Wiki
    • External Wiki
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • CMake
  • CMakeCMake
  • Issues
  • #21543

Closed
Open
Created Dec 02, 2020 by Kevin L. Rak@kevinlrak

GoogleTest Disabled Test Detection (trivial fix)

This is a two-character fix. GoogleTest defines tests that begin with DISABLED_ as disabled, but the GoogleTestAddTests module disables any that begin with DISABLED (note the missing underscore). I don't have time to fork and clone at the moment, but this should be very trivial to fix for anyone who already has the local environment setup.

Proposed change goes here: https://gitlab.kitware.com/cmake/cmake/-/blob/v3.19.1/Modules/GoogleTestAddTests.cmake#L139

Change from:

if(suite MATCHES "^DISABLED" OR test MATCHES "^DISABLED")

Change to:

if(suite MATCHES "^DISABLED_" OR test MATCHES "^DISABLED_")
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
3.20.0
Milestone
3.20.0 (Past due)
Assign milestone
Time tracking
None
Due date
None