Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
CMake
CMake
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,246
    • Issues 3,246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 11
    • Merge Requests 11
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • External Wiki
    • External Wiki
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • CMake
  • CMakeCMake
  • Issues
  • #19970

Closed
Open
Opened Nov 13, 2019 by Craig Scott@craig.scottMaintainer

Clarify REUSE_FROM behavior of target_precompile_headers()

I'm updating the docs for PCH, as discussed in #19953 (comment 652323). In cleaning up the wording while I'm there, I noticed that if you use the second signature of target_precompile_headers() which has the REUSE_FROM keyword, the result of calling that sets not just the target's PRECOMPILE_HEADERS_REUSE_FROM property, it also sets its PRECOMPILE_HEADERS property. Was that intended? I only noticed because if I tried to invoke the REUSE_FROM form on the same target twice, the warning I get is the following:

PRECOMPILE_HEADERS property is already set on target ("myapp")

I was expecting only PRECOMPILE_HEADERS_REUSE_FROM to be set as a result of the call, but this error talks about PRECOMPILE_HEADERS instead. Some quick checking confirmed that PRECOMPILE_HEADERS is indeed populated by the call. @cristianadam Can you clarify the intended behavior of this? I'll then incorporate that into my doc updates.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
3.16.0
Milestone
3.16.0 (Past due)
Assign milestone
Time tracking
None
Due date
None
Reference: cmake/cmake#19970