Dāvis Mosāns authored 8 years ago and Brad King committed 8 years ago

std::basic_filebuf::open(const wchar_t *) isn't part of C++ standard
and it's only present for MSVC but it isn't present in libstdc++ (MinGW)
so we implement this functionality using GNU libstdc++ stdio_filebuf
extension and _wfopen function.

Change-Id: I7df7a1b22ba272db23c8d962cb66ec71a278ef06

Dāvis Mosāns authored 8 years ago and Brad King committed 8 years ago

Reduce code duplication.

Change-Id: Ic0fcee68286c8e67bcb6fb58cbc7ca71c30f4c36

Dāvis Mosāns authored 8 years ago and Brad King committed 8 years ago

Change-Id: I3cdbcb846a205b211ac0f597e2c1c940dc0b7268

Dāvis Mosāns authored 8 years ago and Brad King committed 8 years ago

Some GetEnv callers only need to know whether an environment variable
exists, so provide a direct query for this.

Change-Id: Ib754cb122b53a2a7cc4801fc7198cf1d612ef6f4

Dāvis Mosāns authored 8 years ago and Brad King committed 8 years ago

On Windows getenv (and putenv) uses ANSI codepage so it needs to be encoded
to internally used encoding (eg. UTF-8). Here we use _wgetenv (and _wputenv)
instead and encode that.

Change-Id: I8cb91f2386eb0efe3ef0a3132d1603217d710b60

Dāvis Mosāns authored 8 years ago and Brad King committed 8 years ago

Revise code layout to make introduction of wide character APIs cleaner.

Change-Id: I22301f07eba1e13b954eb938da3305f269d8b754

Dāvis Mosāns authored 8 years ago and Brad King committed 8 years ago

Change-Id: If7753c828c211998b76a1706ca7fd35fbb4c1f71

When using `putenv("A=")` to approximate removal of `A` from the
environment we must not free the buffer afterward because the string
is still actually in the environment.

Change-Id: I4d2455ca604a2e216123a3d2afafb64ca260d105
Reported-by: James Johnston <johnstonj.public@codenest.com>

Move `kwsysEnv` storage management into a `kwsysEnvSet` base class.

Change-Id: I022a8620e570394bb1871515c8275c969535c693
Inspired-by: Dāvis Mosāns <davispuh@gmail.com>

This header is no longer used by any KWSys clients.

Change-Id: Ia83ed98403c881aa28c9a531111cc1441646b47f

Ben Boeckel authored 8 years ago and Brad King committed 8 years ago

Matches the opening of this #ifdef.

Change-Id: I044645285faaed0ac96b5f40af027ec07b73d825

Ben Boeckel authored 8 years ago and Brad King committed 8 years ago

If the path is a junction, pass if the junction was successfully
deleted. Not doing so triggers an INVALID_FILE_HANDLE error when
DeleteFileW is called later, not that the path doesn't exist.

Change-Id: I8957a0ca0704f7f950faeac90b15e8c61c5f5a90

Felix Geyer authored 8 years ago and Brad King committed 8 years ago

The Debian package checker tool (lintian) detected typos.

Change-Id: Ic7896c78d5cbac39287bf5e9c925208e53f3d348

_WIN32 is the actual define for Windows. WIN32 is a CMake-ism.

Change-Id: Iea9f69ab1719325703a3c9a6cacdd6ecf13dbc34

Zack Galbreath authored 9 years ago and Brad King committed 9 years ago

Change-Id: I7d588cb060ea17ed4221c55b866cbbebab983e3c

Mariusz Pluciński authored 9 years ago and Brad King committed 9 years ago

Change-Id: If1ef48369feca8bfd0a3831146fae6688f934b0c

Change-Id: Id2f7882d16bf05cfd50983b4fb660fec1d12b5b4

Change-Id: I0c1db70531f1ef3823146fcefc2a8f8ee67f8f2a

Change-Id: I8bd634ecc1bdc035492c145d3a66478dee56bb06

Zack Galbreath authored 9 years ago and Brad King committed 9 years ago

Recompute `TimeoutTime` after `Timeout` changes so that one may modify
the timeout of a process after it has started running by calling the
normal `kwsysProcess_SetTimeout` method.

Change-Id: I460a02d0d3c5f107b844abb56e39f5c844e7e3fb

Ben Boeckel authored 9 years ago and Brad King committed 9 years ago

Junction points can exist in directories which may be manipulated within
CMake. The problem is that junction points are currently completely
unsupported within CMake. Since junctions need special API calls to
manipulate, DeleteFileW does not work and instead DeviceIoControl must
be used. Token privilege API calls must also be used to be able to
actually open the junction points.

Change-Id: I3e4ff3b7a600146ac3574d2b17890eef07d06496

Chuck Atkins authored 9 years ago and Brad King committed 9 years ago

Change-Id: I694df81c1c62bd538ef02cb2846b6932870dbefe

Costy Petrisor authored 9 years ago and Brad King committed 9 years ago

Update sources using KWSYS_HEADER to make the corresponding ".in"
includes consistent.

Change-Id: I9414edf93928386ffc38e0fd885edd0b7ddb2886

As described in the issues below, Embarcadero compilers emit a spurious warning
when including windows.h, if compiling with the C (not C++) language.

    http://qc.embarcadero.com/wc/qcmain.aspx?d=104595
    [BCC32 Warning] winnt.h(14966)...

    http://qc.embarcadero.com/wc/qcmain.aspx?d=127681
    Annoying warnings upon inclusion of <windows.h> in .C source file

Change-Id: Ie8014edea7e8bbdd76f4555ec2d6cd6d90490032

Use the GetShortPathNameW return value to allocate a buffer of the
required size.  The previous assumption that the "short" path will
always require less space than the original path is incorrect.

CMake-Issue: 15892
Inspired-by: Jan van Dorsten <dorsten@boehme-weihs.de>
Change-Id: I5845752710560b3e71a2f5eaf334dd676f5b3a9d

Jan van Dorsten authored 9 years ago and Brad King committed 9 years ago

Use a `std::string` instead of `new char`.

Change-Id: I88afe09990c6dd881c813df963ccd0031dcea301

The ICC frontend on OSX is clang, and therefore the "__clang__" define exists,
but it doesn't support the clang diagnostic pragma syntax.

Change-Id: I6947bd22c77af8066b85a6b00be7cf6019e7d06e

Clinton Stimpson authored 9 years ago and Brad King committed 9 years ago

When peeking in a file for a byte order mark, if the file is short
enough to reach end-of-file, clear the istream flags.

CMake-Issue: 15890
Change-Id: I1fa3a1b94b47ad46b568b00b7b82b5380cbfcb21

This header is no longer used by any KWSys clients.

Change-Id: I9362a7053b2f24f6bacf2bbe89dbfceeaabe70ae

This header is no longer used by any KWSys clients.

Change-Id: Ifca2c6aec5d4b3068774d8398719376d61706d53

This was used only for an old VS 6 version that did not support
conversion of `unsigned __int64` to `double`.  Support for this compiler
has been dropped from KWSys clients that used the macro.

Change-Id: Ia61beaa0251fc2b6d77632af3e610c08f64d11eb

FileIsDirectory() will return false if the given path does not exist, so the
call to FileExists() is redundant.

Change-Id: I46b3dde9150d6f24a436c4d2f9dd6e2d21c57638

SystemTools::FileExists() can already check this case. These instances were
forgotten in commit 0adafb51 (SystemTools: use
FindProgram() overload that checks for directory). The summary says
"FindProgram()", but it meant to be "FileExists()".

Change-Id: I5ef2919d915fffe3a70e3f47d0c49e18951e66eb

Neither this variable nor the original one are modified before the copy gets
later overwritten, so just use the original variable to entirely avoid needless
copy operations.

Change-Id: I67438e774d68c797e77dc4f4a2b50bbad131a9da

This vector will only be filled in an #ifdef, so put the only user of it outside
that first #ifdef into an according one. This means Un*x platforms do not need
to carry that dead code around anymore.

Change-Id: Ia5071c36ed253e7cea63ccfa516add61799877f6

Change-Id: I59c150ef46c87bea36bab2822ebd0643aa7b7c2b

Change-Id: I45efddc1638965d17f0207cdf900a44aef8bf0e8

Rolf Eike Beer authored 9 years ago and Brad King committed 9 years ago

The list of possible extensions is only filled inside an #ifdef, so the whole
usage of this list can be moved into that #ifdef's, too. The loop can be
completely avoided if it's already known that the list will not be filled at
all.

Change-Id: I89a87115babf68f9bf99d4ad523cb0851c252cd9

Rolf Eike Beer authored 9 years ago and Brad King committed 9 years ago

This converts all constructs like

  FileExists(f) && !SystemTools::FileIsDirectory(f)

to

  FileExists(f, true)

which behaves the same.

Change-Id: Iadb26fb792db032a396bc54c58f7b902c5e054b2

Dmitry Marakasov authored 9 years ago and Brad King committed 9 years ago

Microseconds range from 0 to 999999, so 1000000 is an overflow which
should be processed as well.

Change-Id: I59873504987d6aa416e87aa7f5cd208983217ace