This also allowed the compiler to notice a mismatch of format specifiers, and so changed %X to %lX.

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

e28d7282 DynamicLoader: Add RTLD_GLOBAL as a supported flag on linux

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Ben Boeckel <ben.boeckel@kitware.com>
Merge-request: !233

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

15effd64 MD5: Fix Clang 13 Wnull-pointer-subtraction warning

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !231

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

f9e45083 CTestConfig: Always set CTEST_DROP_METHOD to https

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !230

Sean McBride authored 3 years ago and Brad King committed 3 years ago

open.cdash.org has long supported https

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

6ccbfc12 SystemTools: Add a Join function

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Mathieu Westphal <mathieu.westphal@kitware.com>
Acked-by: Ben Boeckel <ben.boeckel@kitware.com>
Merge-request: !229

* The Join function joins a vector of strings in a single string with
  a specific separator in between

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

4ef5b106 SystemTools: Ensure Windows Vista APIs are available before using them

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !228

Steven Boswell authored 3 years ago and Brad King committed 3 years ago

Since commit 3683e5ab (SystemTools: Implement CreateSymlink and
ReadSymlink on Windows, 2021-05-06) we use `CreateSymbolicLinkW`, which
is only available under Windows Vista or later.

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

a6a0bb15 Status: use the new IsSuccess method
40bbf3fd Status: offer an `IsSuccess` method

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !227

It is much easier to read (especially when coming from the POSIX side of
things).

This method makes usage much easier to read than prepending with `!!` or
`static_cast<bool>` to extract a boolean from the structure.

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

5d4c8b04 SystemInformation: Simplify demangle buffer management

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !226

If the buffer we pass to `__cxa_demangle` is not large enough, it will
be reallocated internally.  Avoid dealing with possibly two allocations
to free by just letting `__cxa_demangle` allocate a suitable buffer.

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

4e69b791 SystemInformation: Add option to explicitly avoid using execinfo

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !225

Đoàn Trần Công Danh authored 3 years ago and Brad King committed 3 years ago

backtrace(3) from libexecinfo in musl will run into crash [1].

Provide an option to disable it explicitly even if libexecinfo is present.

1: https://www.openwall.com/lists/musl/2021/07/17/1

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

7079df74 SystemTools: Fix GetOperatingSystemNameAndVersion empty string return

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !224

Dženan Zukić authored 3 years ago and Brad King committed 3 years ago

Avoid undefined behavior caused by constructing `std::string` from `0`.

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

b954dd54 testDynamicLoader: Use LIBC_SO if LIBDL_SO is not defined by glibc anymore.

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !223

Björn Esser authored 3 years ago and Brad King committed 3 years ago

`LIBC_SO` is a more long-term choice, suitable for new targets that may
no longer define `LIBDL_SO`.

Signed-off-by: Björn Esser <besser82@fedoraproject.org>

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

ab959cd2 SystemInformation: fix typo in comment
df91e5f1 EncodingC: use NULL for pointers

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !222

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

b4a2a03c testDynamicLoader: Use LIBDL_SO macro if defined.

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !221

Starting with glibc v2.34 there is no external version of libdl.so
anymore.  It has been merged into the glibc libc.so.

Assuming libdl.so will be present will break the test, thus the
LIBDL_SO macro should be used.  If the macro is not defined on
the system, we ensure it will be defined using the previously
hardcoded value.

Signed-off-by: Björn Esser <besser82@fedoraproject.org>

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

e65c5693 testSystemTools: apply root-check to more systems

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Ben Boeckel <ben.boeckel@kitware.com>
Merge-request: !220

Adriaan de Groot authored 3 years ago and Brad King committed 3 years ago

The TestFileAccess test fails on FreeBSD (probably others) with this message:

    TestFileAccess incorrectly indicated that this is a writable file

if the test is run as root; apply the same cop-out as on Linux and don't
run it when testing as root.

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

3683e5ab SystemTools: Implement CreateSymlink and ReadSymlink on Windows
fd2ec23d SystemTools: Implement FileIsSymlink using canonical reparse structure

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !216

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

1ea48581 ProcessUNIX: Fix kwsysProcessesSignalHandler() if !KWSYSPE_USE_SIGINFO

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !219

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

8f3c4879 Status: Fix GetWindows return type

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !218

- `struct sigaction&` is not a valid C type name, its usage suggests
  that it was intended to be a pointer.
- `newSigChldAction` does not exist, appears to have just been forgotten
  in a change?
- `return 0` from a void function.

A Windows-native error is an unsigned integer.