bunch of missing override qualifiers on destructors

Remove a few unnecessary virtual keywords as well.

Kitware Robot authored 5 years ago and Ben Boeckel committed 5 years ago

Run the `clang-format.bash` script to update all our C and C++ code to a
new style defined by `.clang-format`.  Use `clang-format` version 8.0.

* If you reached this commit for a line in `git blame`, re-run the blame
  operation starting at the parent of this commit to see older history
  for the content.

* See the parent commit for instructions to rebase a change across this
  style transition commit.

Kitware Robot authored 5 years ago and Ben Boeckel committed 5 years ago

clang-format treats them as declarations and formats accordingly.

Kitware Robot authored 5 years ago and Ben Boeckel committed 5 years ago

clang-format takes the lack of a semicolon as if it were an attribute or
some other "chainable" call leading to bogus indentation. By using
semicolons on all macro calls, the formatting comes out the way it
should.

Kitware Robot authored 5 years ago and Ben Boeckel committed 5 years ago

Includes a few changes related to extraneous whitespace fixes and
deduplication of headers as well.

See the vtkCellArray.h class docs for details.

int vtk(.*)::ProcessRequest
->
vtkTypeBool vtk\1::ProcessRequest

int\s*ProcessRequest
->
vtkTypeBool ProcessRequest

Plus a few manual changes missed due to newlines, etc.

When using a color scheme, the text property was set to an unsigned
char rather than a double. This overflow was detected by the dynamic
analysis of the VTK dashboard.

for old gcc compilers that seem to produce different results
such as gcc (GCC) 8.2.1 20181215

Before transforming the skippedWord string, the string was not resized
to the length of the skippedWord. This caused some platforms to report
1 skipped word, while other platforms crashed. The UnitTestWordCloud
is updated to reflect the properly calculated skipped words.

Thanks to Ken for finding this bug.

 LocalWords:  WordCloudBug Infovis ThirdParty vtkEventData
 LocalWords:  vtkGenericOpenGLRenderWindow

Older versions of GCC do not implement regex. The first working
version was 4.9. See https://tinyurl.com/yy7lvhp3 for more details.

Instead of regex use vtksys::RegularExpressions for older gcc's.

Cory Quammen authored 5 years ago and Bill Lorensen committed 5 years ago

vtkWordCloud is an Image Source that creates a word cloud.

Word Clouds, AKA Tag Clouds, are a text visualization technique that displays individual works with properties that depend on the frequency of a word in a document. Numerous options are available, including the color of the words, size of the words, the orientation of the words, font files, and mask files.
Word Clouds, AKA Tag Clouds, are a text visualization technique that displays individual works with properties that depend on the frequency of a word in a document.  vtkWordCloud varies the font size base on word frequency.

Word Clouds are useful for quickly perceiving the most prominent terms in a document. Also, Word Clouds can identify trends and patterns that would otherwise be unclear or difficult to see in a tabular format. Frequently used keywords stand out better in a Word Cloud. Common words that might be overlooked in tabular form are highlighted in the larger text, making them pop out when displayed in a word cloud.

There is some controversy about the usefulness of word clouds. Their best use may be for presentations. Word clouds can be used to "compare" texts from similar subjects, e.g., Presidential Inaugural Addresses, job candidate comparisons, etc.

Several methods are available to customize the resulting visualization. The class provides defaults that provide a reasonable result.

BackgroundColorName - The vtkNamedColors name for the backgound (MidNightBlue).

BWMask - Mask image has a single channel(false). Mask images typically have three channels (r,g,b).

ColorDistribution - Distribution of random colors(.6 1.0), if WordColorName is not empty.

ColorSchemeName - Name of a color scheme from vtkColorSeries to be used to select colors for the words (), if WordColorName is empty.

DPI -  Dots per inch(200) of the rendered text. DPI is used as a scaling mechanism for the words. As DPI increases, the word size increases. If there are too, few skipped words, increase this value, too many, decrease it.

FontFileName - If empty, the built-in Arial font is used(). The FontFileName is the name of a file that contains a TrueType font.

FontMultiplier - Font multiplier(6). The final font size is this value * the word frequency.

Gap - Space gap of words (2). The gap is the number of spaces added to the beginning and end of each word.

MaskColorName - Name of the color for the mask (black). This color is the name of the vtkNamedColors that defines the foreground of the mask. Usually black or white.

MaskFileName - Mask file name(). If a mask file is specified, it will be used as the mask. Otherwise, a black square is used as the mask. The mask file should contain three channels of unsigned char values. If the mask file is just a single unsigned char, specify turn the boolean BWMask on.  If BWmask is on, the class will create a three channel image using vtkImageAppendComponents.

MaxFontSize - Maximum font size(48).

MinFontSize - Minimum font size(8).

MinFrequency - Minimum word frequency accepted(2). Word with frequencies less than this will be ignored.

OffsetDistribution - Range of uniform random offsets(-size[0]/100.0 -size{1]/100.0)(-20 20). These offsets are offsets from the generated path for word layout.

OrientationDistribution - Ranges of random orientations(-20 20). If discrete orientations are not defined, these orientations will be generated.

Orientations - Discrete orientations for displayed words. If present, this overrides OrientationDistribution.

ReplacementPairs - Replace the first word with another second word (). The first word is also added to the StopList.

Sizes - Size of image(640 480).

StopWords - User provided stop words(). vtkWordCloud has built-in stop words. The user-provided stop words are added to the built-in list.

Title - Add this word to the document's words and set a high frequency, so that is will be rendered first.

WordColorName - Name of the color for the words(). The name is selected from vtkNamedColors. If the name is empty, the ColorDistribution will generate random colors.

Fixes: #16831

REQUIRED and QUIET are mutually exclusive, so their combination makes no sense.

Found via `codespell`

This fixed issues were:

clarifyCondition,Common/Core/vtkLargeInteger.cxx:355
identicalInnerCondition,Filters/Texture/vtkTextureMapToPlane.cxx:103,warning,Identical inner 'if' condition is always true.
nullPointerArithmeticRedundantCheck,Rendering/GL2PSOpenGL2/vtkOpenGLGL2PSHelperImpl.cxx:173,warning,Either the condition '!data' is redundant or there is pointer arithmetic with NULL pointer.
identicalInnerCondition,Filters/FlowPaths/vtkModifiedBSPTree.cxx:1069,warning,Identical inner 'if' condition is always true.
identicalInnerCondition,Rendering/OpenGL2/vtkOSOpenGLRenderWindow.cxx:199,warning,Identical inner 'if' condition is always true.
nullPointerArithmeticRedundantCheck,Infovis/BoostGraphAlgorithms/vtkBoostGraphAdapter.h:222,warning,Either the condition 'iter!=0' is redundant or there is pointer arithmetic with NULL pointer.

The vtkTestingRenderingDriver.cmake changed cause many many warnings in files generated from it.

Found via `codespell -q 3 -I ../vtk-whitelist-words.txt --skip="./ThirdParty,./Utilities"`

Kitware Robot authored 6 years ago and Brad King committed 6 years ago

Populate a script with `map_<md5>=<sha512>` variable settings and
then run the following to convert the content link files:

    git ls-files -- '*.md5' | while read f; do
      md5="$(cat "$f")"
      sha512="$(eval echo \${map_$md5})"
      rm "$f"
      echo $sha512 > ${f%.md5}.sha512
    done

154 occurances of ;;\n

This required some clean up, because the automatic changes borked a couple of files, but mostly resulted in stupid whitespacing. A few find/replace fixed things up.

There are now some duplicate semis because it did changes like:

  ~AMRIndexIterator() override{};
to
  ~AMRIndexIterator() override= default;;

Note there was a pointless semi before, which clang-tidy didn’t expect / account for.

My next commit will remove them.

Found via `codespell` and `grep`

I was surprised how many there were.  But no bugs at least, as best as I could tell.

Removed a few useless semi-colons that were nearby.

Added whitespace to some other false positives.

Found via `codespell`