It was using string literal addresses as a lookup
assuming they would be shared when they are not
always shared.

In 2 cases, made trivial use of NewInstance, so that it’s not unused.

Added vtkSpanSpace performance improvements and integration methods.
Integrated the class with vtkContour3DLinearGrid to accelerate
the contouring operation.

first some local variables were conflicting with numeric
constants. Second superclass ivars were dusplicated.

Replace custom hash map with std::unordered_map. This simplifies
the implementation.

- Added VTK_DEPRECATED macro, which can be used to deprecated a class. Used it to deprecate vtkExtractArraysOverTime and vtkPExtractArraysOverTime. Unwrapped their New method from VTK_LEGACY, since the vtkTypeMacro in the line after invokes New (causing a warning of the use of a deprecated method).
- Deprecated vtkTimerLog::AllocateLog and replaced remaining uses of it
- Wrap vtkContourGrid::ComputeGradients in VTK_LEGACY_REMOVE
- Added a macro to decorate printf-style functions, like vtkTimerLog::FormatAndMarkEvent
- Exclude FormatAndMarkEvent() from wrapping to avoid -Wformat-security warning, but also because the parameter is not guarded against uncontrolled format string attacks.

In the past, folks have complained about poor performance
in debugging builds. These new iterators are written such
that their complexity optimizes out, but there is still a
lot of complexity. On debugging builds without optimization,
this can really get in the way and start slowing things down.

In anticipation of this request, I'm adding a CMake option
VTK_ALWAYS_OPTIMIZE_ARRAY_ITERATORS which, as you might guess,
will always optimize array iterators on platforms that
support selective optimization in debug builds.

All of the above macros are now behind a VTK_LEGACY_REMOVE check
as we require a C++11 compiler and the macros add no value.

Jerome Dubois authored 6 years ago and Sebastien Jourdain committed 6 years ago

This work was done by the CEA:
- HyperTreeGrid class now inherits from vtkDataObject instead of vtkDataSet
- Improved HyperTree (HT) class while keeping HT flexible.
- Complete rewrite of (Super)Cursors, more robust and efficient implementation.
- Propagate HT/Cursors refactoring to filters/readers/sources.
- Further optimizations of some filters.

Our thanks go to Los Alamos National Laboratory and Kitware for their support
in the integration of our developments.

Thanks @sebastien.jourdain, @demarle and @patchett2002.

ToDo (@CEA), review comments in code.

Co-authored-by: Jerome Dubois <Jerome.Dubois@cea.fr>
Co-authored-by: Guenole Harel <Guenole.Harel@cea.fr>
Co-authored-by: Jacques-Bernard Lekien <Jacques-Bernard.Lekien@cea.fr>

Two years have passed since I conditionalized Borland workarounds to apply to only old versions, and no one has complained.  Either newer Borland compliers don’t have these issues, or no one uses Borland compilers at all anymore.

Some remaining comment typos missed from the previous commit.

Found via `codespell`

vtkChartBox: replaced a retained, returned pointer with a stored
value.

vtkChartXY: Added check for range[0] == range[1] and avoid division by zero.

vtkFunctionParser: Added check for division of a vector by 0.0.

vtkUnstructuredGridQuadricDecimation: first time through loop,
lasterror is 0.0. Avoid division by zero by checking for 0.0.

vtkChartBox: replaced a retained, returned pointer with a stored
value.

vtkChartXY: Added check for range[0] == range[1] and avoid division by zero.

vtkFunctionParser: Added check for division of a vector by 0.0.

vtkUnstructuredGridQuadricDecimation: first time through loop,
lasterror is 0.0. Avoid division by zero by checking for 0.0.