The DeleteAction calls RemoveHandle and DeleteSeed whereas DeleteSeed,
in turn, calls RemoveHandle. This change ensures that the handles are
removed only once.

Removed the unnecessary duplicate setting of HandleSize in
vtkWidgetRepresentation.

Move a lot of code into OpenGL and simplify. Introduce
ShowWindow and update UseOffScreenBuffers. These two booleans can
work together to handle all four cases. You can...

ShowWindow = 0 UseOffScreenBuffers = 0
You are using a window to render but the window
is not current shown on the display

ShowWindow = 1 UseOffScreenBuffers = 0
You are rendering into a window and the window
is shown on the screen. The default.

ShowWindow = 0 UseOffScreenBuffers = 1
You are rendering into a framebuffer offscreen
and the window used for the opengl context is not
shown on the display.

ShowWindow = 1 UseOffScreenBuffers = 1
You are rendering into a framebuffer offscreen
and there is a window that is also visible with it's
own content.

For backwards compatability OffScreenRendering now
just sets ShowWindow(false) and UseOffScreenBuffers(true)

Other more specific approaches, methods have been removed.

Mapped has been fixed a bit in some backends to properly
indicate if the window is mapped (as opposed to created)

Due to a bug in the ScaleContour function, contours were arbitrarily shifted when scaling them.

PolyLineWidget::EndWidgetInteraction can add and remove
points, we need to make sure that the representation is
updated, this is done by invoking InteractionEvent

Disabling the widget ensures that the current renderer is set to nullptr
in vtkAbstractWidget. However, some widgets may still keep their
representation in the renderer. This change ensures that the
representation is removed when the widget is destroyed irrespective of
whether the current renderer is set on the widget.

This change fixes Slicer issue:
https://issues.slicer.org/view.php?id=4628

Had to update TestChartUnicode baseline to get it passing.

Found via `codespell`

The new mode can be enabled by setting ShowInactive on the handle widget
which allows showing uninteractive handle geometry when the widget
is disabled.

Also added API to be able to set active handle externally

This should fix issue 4609 in slicer, where the box
representation's child actors were not getting the proper
shader replacements under depth peeling.

Confusingly, IsArrayAnAttribute() must stay as int.

int +HasTranslucentPolygonalGeometry
->
vtkTypeBool HasTranslucentPolygonalGeometry

int +vtk(.*)::HasTranslucentPolygonalGeometry
->
vtkTypeBool vtk\1::HasTranslucentPolygonalGeometry

- Changed some to be const also.
- Replaced others with call to ClampValue method.
- Changed some from int to bool.
- In a couple of cases the variable was unused, removed it.

vtkMath::Round converts double to int, as opposed to long.  Both can be lossy, but the former much more so.

Replaced some uses with std::round(), some with std::lround().

Eliminated the long->int truncation as much as possible, but kept it in many instances.

Found via `codespell`

This allows customizations in consumer applications.

The actual data was updated correctly in the BoxWidget
code, but the wrong object was being marked as modified.

The rendering code got smarter at some point and now
only rebuilds VBOs when the corresponding cell array
has been modified. Marking the entire polydata as modified
is no longer sufficient to update the on-device
representation of the highlighted face.

This patch fixes the BoxWidget so that the active face is
used for highlighting instead of getting "stuck" on an
arbitrary face.

Found via `codespell`

Found via `codespell -q 3 -I ../vtk-whitelist-words.txt --skip="./ThirdParty,./Utilities"`

missingOverride,Examples/GUI/Win32/SampleMFC/SampleDoc.h:47
missingOverride,Examples/GUI/Win32/SampleMFC/vtkMFCRenderView.h:49
missingOverride,Examples/GUI/Win32/SampleMFC/vtkMFCRenderView.h:50
missingOverride,Examples/GUI/Win32/SampleMFC/vtkMFCRenderView.h:52
missingOverride,Examples/GUI/Win32/SampleMFC/vtkMFCRenderView.h:54
missingOverride,Examples/GUI/Win32/SampleMFC/vtkMFCRenderView.h:61
missingOverride,Examples/GUI/Win32/SampleMFC/vtkMFCRenderView.h:62
missingOverride,Examples/GUI/Win32/SampleMFC/vtkMFCRenderView.h:69
missingOverride,Examples/GUI/Win32/SampleMFC/vtkMFCRenderView.h:70
missingOverride,Interaction/Widgets/vtkXYPlotRepresentation.h:60
missingOverride,Interaction/Widgets/vtkXYPlotRepresentation.h:61
missingOverride,Interaction/Widgets/vtkXYPlotRepresentation.h:62
missingOverride,IO/ADIOS/FunctionPointers.h:114
missingOverride,IO/Video/vtkMILVideoSource.h:104
missingOverride,IO/Video/vtkMILVideoSource.h:243
missingOverride,IO/Video/vtkMILVideoSource.h:249
missingOverride,IO/Video/vtkMILVideoSource.h:259
missingOverride,IO/Video/vtkMILVideoSource.h:79
missingOverride,IO/Video/vtkMILVideoSource.h:84
missingOverride,IO/Video/vtkMILVideoSource.h:89
missingOverride,IO/Video/vtkMILVideoSource.h:94
missingOverride,IO/Video/vtkMILVideoSource.h:99
missingOverride,Rendering/OpenGL2/vtkEGLRenderWindow.h:206
missingOverride,Rendering/OpenGL2/vtkEGLRenderWindow.h:219
missingOverride,Rendering/OpenGL2/vtkEGLRenderWindow.h:220
missingOverride,Rendering/OpenGL2/vtkEGLRenderWindow.h:68
missingOverride,Rendering/OpenGL2/vtkOSOpenGLRenderWindow.h:238
missingOverride,Rendering/OpenGL2/vtkOSOpenGLRenderWindow.h:239
missingOverride,Rendering/OpenGL2/vtkOSOpenGLRenderWindow.h:66
missingOverride,Rendering/OpenVR/vtkOpenVRDefaultOverlay.h:37
missingOverride,Rendering/OpenVR/vtkOpenVRDefaultOverlay.h:43
missingOverride,Rendering/OptiX/vtkOptiXCompositePolyDataMapper2Node.h:45,style,The function 'Render' overrides a function in a base class but is not marked with a 'override' specifier.
missingOverride,Utilities/Benchmarks/GLBenchmarking.cxx:74
missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:162
missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:164
missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:166
missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:270
missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:273
missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:276
missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:409
missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:414
missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:419
missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:532
missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:534
missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:536
missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:58
missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:60
missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:62
missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:658
missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:660
missingOverride,Utilities/Benchmarks/vtkRenderTimingTests.h:662
missingOverride,IO/ADIOS/ADIOSWriter.cxx:159,style,The function 'GetInt' overrides a function in a base class but is not marked with a 'override' specifier.
missingOverride,IO/ADIOS/FunctionPointers.h:31,style,The function 'ExecVoid' overrides a function in a base class but is not marked with a 'override' specifier.
missingOverride,IO/ADIOS/FunctionPointers.h:50,style,The function 'operator()' overrides a function in a base class but is not marked with a 'override' specifier.
missingOverride,IO/ADIOS/FunctionPointers.h:69,style,The function 'operator()' overrides a function in a base class but is not marked with a 'override' specifier.
missingOverride,IO/ADIOS/FunctionPointers.h:90,style,The function 'operator()' overrides a function in a base class but is not marked with a 'override' specifier.

The widget waited for a left click when re-enabled. This leads to an
additional seed placed at the site of the existing seed before
registering that there is already a seed present.

Kitware Robot authored 6 years ago and Brad King committed 6 years ago

Populate a script with `map_<md5>=<sha512>` variable settings and
then run the following to convert the content link files:

    git ls-files -- '*.md5' | while read f; do
      md5="$(cat "$f")"
      sha512="$(eval echo \${map_$md5})"
      rm "$f"
      echo $sha512 > ${f%.md5}.sha512
    done

This follows up commit d6d05b2a (ExternalData: Convert content links
from MD5 to SHA512, 2018-05-14) to convert content links added in topic
branches that started before the main conversion.

Found via `codespell`

Ken Martin authored 6 years ago and Brad King committed 6 years ago

make image difference symmetric to catch some
failures that were slipping through. This exposed
a number of valid images that were no longer
correct and needed to be replaced.

Kitware Robot authored 6 years ago and Brad King committed 6 years ago

Populate a script with `map_<md5>=<sha512>` variable settings and
then run the following to convert the content link files:

    git ls-files -- '*.md5' | while read f; do
      md5="$(cat "$f")"
      sha512="$(eval echo \${map_$md5})"
      rm "$f"
      echo $sha512 > ${f%.md5}.sha512
    done

It was only possible to add a point on a current line and move it.
It is now possible to insert a point everywhere, a line will be created between this point
and the last existing one.
The key combinaison is alt + left click.
The point is pushed before the first point or after the last one depending on previous selection.

Please, note that some window manager (like KDE) already define alt + left click event,
it must be disabled to use this feature.

This avoids a code generation problem with std::min/max in MSVC 2013.

Hat tip to Boris Basic for the recommendation.